Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip TestAccDataSourceNotFound/vcd_external_network test with org user #470

Merged
merged 2 commits into from
Mar 9, 2020

Conversation

Didainius
Copy link
Collaborator

@Didainius Didainius commented Mar 9, 2020

Data source automated tests try to use automated data source test for vcd_external_network but it does not work in org user mode as vcd_external_networkrequires admin privileges. This PR fixes it (skips TestAccDataSourceNotFound/vcd_external_network sub-test when suite user is not sysadmin.

VCD_TEST_ORG_USER=1 go test -v -tags ALL -run "TestAccDataSourceNotFound" .

@Didainius Didainius self-assigned this Mar 9, 2020
@ghost ghost added the size/XS label Mar 9, 2020
Copy link
Contributor

@dataclouder dataclouder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Didainius Didainius merged commit b8f9135 into vmware:master Mar 9, 2020
@Didainius Didainius deleted the datasource-fix-user-mode branch March 9, 2020 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants