Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increment vCD API version from 27.0 to 29.0 #396

Merged
merged 33 commits into from
Nov 18, 2019
Merged

Increment vCD API version from 27.0 to 29.0 #396

merged 33 commits into from
Nov 18, 2019

Conversation

vbauzys
Copy link
Contributor

@vbauzys vbauzys commented Nov 15, 2019

Ref: vmware/go-vcloud-director#263
Just updated govcd reference.

Needs testing to verify everything still fine.

vbauzys added 30 commits July 15, 2019 15:39
Signed-off-by: Vaidotas Bauzys <[email protected]>
Merge branch 'master' of github.com:terraform-providers/terraform-provider-vcd
Merge branch 'master' of github.com:terraform-providers/terraform-provider-vcd
Merge branch 'master' of github.com:terraform-providers/terraform-provider-vcd
Signed-off-by: Vaidotas Bauzys <[email protected]>
@vbauzys vbauzys self-assigned this Nov 15, 2019
@vbauzys vbauzys requested review from Didainius, lvirbalas and dataclouder and removed request for Didainius and lvirbalas November 15, 2019 07:07
Copy link
Contributor

@dataclouder dataclouder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Acceptance and binary tests pass 9.5, 10.0

Copy link
Collaborator

@Didainius Didainius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got this passing for 9.7 and 10.

@vbauzys
Copy link
Contributor Author

vbauzys commented Nov 18, 2019

Got passed with 9.0 and 9.5

Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and thanks for this solid testing round!

@vbauzys vbauzys merged commit f9ce57e into vmware:master Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants