Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements needed for vApp resource #379

Closed
vbauzys opened this issue Oct 30, 2019 · 4 comments
Closed

Improvements needed for vApp resource #379

vbauzys opened this issue Oct 30, 2019 · 4 comments
Assignees

Comments

@vbauzys
Copy link
Contributor

vbauzys commented Oct 30, 2019

  • accept_all_eulas and power_on fields isn't populated after import. We now that accept_all_eulas cannot be read and power_on is not read because it is not reliable, and is replaced by two more properties. We don't mentioned that documentation.
  • after datasource is read - only less than half fields is available
@dataclouder
Copy link
Contributor

dataclouder commented Oct 30, 2019

When we developed importing and data source for vApp, we decided to deprecate all properties that refer to implicit creation of a VM, such as accept_all_eulas, ip, network_name, etc , and we did not invest time into importing any of these properties into the state. Same goes for data source. Only non-deprecated properties are shown.

@vbauzys
Copy link
Contributor Author

vbauzys commented Oct 30, 2019

Thank you for update, you are right. Yet in data source documentation we have:

## Attribute reference

* `href` - The vApp Hyper Reference
* `metadata` -  Key value map of metadata to assign to this vApp. Key and value can be any string. 
* `power_on` -  A boolean value stating if this vApp should be powered on. Default is `true`
* `guest_properties` -  Key value map of vApp guest properties.
* `status` -  The vApp status as a numeric code
* `status_text` -  The vApp status as text.

@lvirbalas
Copy link
Collaborator

I see, so power_on is deprecated but the docs tell it's readable, thanks, nice catch.

@lvirbalas lvirbalas changed the title Improvements needed for vAPP resource Improvements needed for vApp resource Oct 31, 2019
@dataclouder
Copy link
Contributor

Fixed in 2.6.0 (PR #386)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants