Fix for protocol upper/lower case handling

[vbauzys]

Now lower case configured required and vCD returns lower case and they match

[lvirbalas]

BTW, in the warning of SNAT and DNAT pages:

Warning: When advanced edge gateway is used and the rule is updated using UI, then Id mapping will be lost and terraform won't find the rule anymore and remove it from state.

Please change:

1. "Id" -> "ID"
2. "terraform" -> "Terraform"

[vbauzys]

BTW, in the warning of SNAT and DNAT pages:

Warning: When advanced edge gateway is used and the rule is updated using UI, then Id mapping will be lost and terraform won't find the rule anymore and remove it from state.

Please change:

1. "Id" -> "ID"

2. "terraform" -> "Terraform"

done

[lvirbalas]

For reference: for those who have protocol not set from previous versions in the state file, this change will lead to a single occurrence of protocol field's value update from upper to lower case during the next plan?

[vbauzys]

For reference: for those who have protocol not set from previous versions in the state file, this change will lead to a single occurrence of protocol field's value update from upper to lower case during the next plan?

this happens today, cause vCD api returns lowercase and everytime update happens

[Didainius]

Never tested before, but should be like that as per https://www.terraform.io/docs/extend/best-practices/versioning.html

IMPROVEMENTS:

• resource/load_balancer: Add ATTRIBUTE argument (support X new functionality) [VMware - Vcloud Air/ Vcloud Director: error: "* Something went wrong: error finding LoginUrl: error parsing error body for non-200 request: EOF" #12]
• resource/subnet: Now better [Allow specifying protocol for SNAT/DNAT rules #22, adding hostname initscript fix to vm #32]

Suggested change

	* `resource/vcd_dnat` added ability to choose network name and type. [GH-282] [GH-292] [GH-293]
	* `resource/vcd_dnat` added ability to choose network name and type. [GH-282, GH-292, GH-293]

[vbauzys]

changed

[lvirbalas]

I used org user and hit this with ext:

vcd_dnat.dnat_ext_net: Creating...

Error: unable to find orgVdcNetwork: my-org-network, err: can't find VDC Network: my-org-network

Let's add a sentence:

* `network_type` - (Optional; *v2.4+*) Type of the network on which to apply the NAT rule. Possible values `org` or `ext`. `ext` requires system administrator privileges. *`network_type` will be a required field in the next major version.*

[lvirbalas]

Much more stable now with using both kinds of networks and changing between them!

[dataclouder]

LGTM