Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fixes for DNAT #292

Merged
merged 37 commits into from
Jul 26, 2019
Merged

Add fixes for DNAT #292

merged 37 commits into from
Jul 26, 2019

Conversation

vbauzys
Copy link
Contributor

@vbauzys vbauzys commented Jul 26, 2019

Fix for bug in reading resource.
Various improvements
Fix for rpc error: code = Unavailable desc = transport is closing

vbauzys added 30 commits June 20, 2019 12:37
@vbauzys
Adding meta data creation with update support
18db1f2 
Signed-off-by: Vaidotas Bauzys <[email protected]>
@vbauzys
Merge branch 'master' into vdc-metadata
72722b6 
Signed-off-by: Vaidotas Bauzys <[email protected]>

# Conflicts:
#	vcd/resource_vcd_org_vdc.go
@vbauzys
Add metadata functionality
cd550d4 
Signed-off-by: Vaidotas Bauzys <[email protected]>
@vbauzys
Address comments
6eb7ea7 
Signed-off-by: Vaidotas Bauzys <[email protected]>
@vbauzys
Change func names
1ff0368 
Signed-off-by: Vaidotas Bauzys <[email protected]>
@vbauzys
Fix naming
55009eb 
Signed-off-by: Vaidotas Bauzys <[email protected]>
@vbauzys
Improve error message
bd71e0b 
Signed-off-by: Vaidotas Bauzys <[email protected]>
@vbauzys
git push origin masterMerge branch 'master' of github.com:terraform-p…
71df2ab 
…roviders/terraform-provider-vcd into vdc-metadata
@vbauzys
bump govcd version to PR
6dd5640 
Signed-off-by: Vaidotas Bauzys <[email protected]>
@vbauzys
Add implementation for support network type and handling IDs.
6828239 
Signed-off-by: Vaidotas Bauzys <[email protected]>
@vbauzys
Add missing file
6585559 
Signed-off-by: Vaidotas Bauzys <[email protected]>
@vbauzys
Merge branch 'master' of github.com:terraform-providers/terraform-pro…
e247d25 
…vider-vcd
@vbauzys
Merge branch 'master' into nat_extNet_support
6e8b128 
Signed-off-by: Vaidotas Bauzys <[email protected]>

# Conflicts:
#	CHANGELOG.md
#	go.mod
#	go.sum
#	vendor/github.com/vmware/go-vcloud-director/v2/govcd/edgegateway.go
#	vendor/modules.txt
@vbauzys
Improve changelog
e2f9b15 
Signed-off-by: Vaidotas Bauzys <[email protected]>
@vbauzys
Fix
2607d2c 
Signed-off-by: Vaidotas Bauzys <[email protected]>
@vbauzys
Improve comments
4df154d 
Signed-off-by: Vaidotas Bauzys <[email protected]>
@vbauzys
Add update unit tests
b1bf437 
Signed-off-by: Vaidotas Bauzys <[email protected]>
@vbauzys
bump govcd to latest version
a8b5121 
Signed-off-by: Vaidotas Bauzys <[email protected]>
@vbauzys
Changes according latest govcd changes
24c4dc4 
Signed-off-by: Vaidotas Bauzys <[email protected]>
@vbauzys
Add improvements
3ee3b67 
Signed-off-by: Vaidotas Bauzys <[email protected]>
@vbauzys
Add comment fix
668ccb1 
Signed-off-by: Vaidotas Bauzys <[email protected]>
@vbauzys
Add improvements in comments
89028b2 
Signed-off-by: Vaidotas Bauzys <[email protected]>
@vbauzys
Add comment fix
72a10b4 
Signed-off-by: Vaidotas Bauzys <[email protected]>
@vbauzys
Add comment fix
103a0f5 
Signed-off-by: Vaidotas Bauzys <[email protected]>
@vbauzys
Removed comments
43cba68 
Signed-off-by: Vaidotas Bauzys <[email protected]>
@vbauzys
Bump govcd version
6d2d64a 
Signed-off-by: Vaidotas Bauzys <[email protected]>
@vbauzys
Change test timeout from 90m to 120m
05b96e6 
Signed-off-by: Vaidotas Bauzys <[email protected]>
@vbauzys
Add check for case when two diff type netw has same name
300c845 
Signed-off-by: Vaidotas Bauzys <[email protected]>
@vbauzys
Add comment fix
0a4bd77 
Signed-off-by: Vaidotas Bauzys <[email protected]>
@vbauzys
git push origin masterMerge branch 'master' of github.com:terraform-p…
cf1e7c2 
…roviders/terraform-provider-vcd
@ghost ghost added the size/S label Jul 26, 2019
vbauzys added 2 commits July 26, 2019 10:13
@vbauzys
Add check when network_type missing
a75e244 
Signed-off-by: Vaidotas Bauzys <[email protected]>
@vbauzys
Improve check
d2860c9 
Signed-off-by: Vaidotas Bauzys <[email protected]>
Didainius
Didainius approved these changes Jul 26, 2019
View reviewed changes
Copy link
Collaborator

@Didainius Didainius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No more crashes and leftover after tests.

@vbauzys vbauzys changed the title Nat ext net support Add fixes for DNAT Jul 26, 2019
dataclouder
dataclouder approved these changes Jul 26, 2019
View reviewed changes
Copy link
Contributor

@dataclouder dataclouder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vbauzys vbauzys merged commit e3d018d into vmware:master Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Didainius Didainius Didainius approved these changes

@dataclouder dataclouder dataclouder approved these changes

@lvirbalas lvirbalas lvirbalas approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vbauzys @lvirbalas @dataclouder @Didainius