Vdc update #275
Merged
Vdc update #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vaidotas Bauzys <[email protected]>
Fix ignoring reservations guarantee values Signed-off-by: Vaidotas Bauzys <[email protected]>
Signed-off-by: Vaidotas Bauzys <[email protected]>
ghost
added
vbauzys
requested review from
Didainius,
lvirbalas and
dataclouder
and removed request for
Didainius and
lvirbalas
Didainius
reviewed
Jul 2, 2019
Didainius
reviewed
Jul 2, 2019
Signed-off-by: Vaidotas Bauzys <[email protected]>
Signed-off-by: Vaidotas Bauzys <[email protected]>
dataclouder
suggested changes
Jul 3, 2019
vcd/resource_vcd_org_vdc.go
Outdated
| Optional: true, | ||
| ForceNew: true, | ||
| Description: "Percentage of allocated memory resources guaranteed to vApps deployed in this VDC. For example, if this value is 0.75, then 75% of allocated resources are guaranteed. Required when AllocationModel is AllocationVApp or AllocationPool. Value defaults to 1.0 if the element is empty.", | ||
| Type: schema.TypeString, |
There was a problem hiding this comment.
Why are we changing the type from Float to String?
This change breaks compatibility.
There was a problem hiding this comment.
Please read explanation I did for Dainius above.
There was a problem hiding this comment.
The explanation above is about the .ID field.
I am talking about changing the type of a field that will break existing Terraform scripts.
There was a problem hiding this comment.
Copying here:
in terraform file nothing changed: memory_guaranteed = 0.5 you still can write like this.
This change is must cause d.GetOk for empty value return 0 and d.Get for type float64 return false. And value can be not provided, 0 or other value.
vcd/resource_vcd_org_vdc.go
Outdated
|
|
||
| adminVdc, err := adminOrg.GetAdminVdcByName(vdcName) | ||
| if err != nil || adminVdc == (govcd.AdminVdc{}) { | ||
| log.Printf("[DEBUG] Unable to find vDC.") |
There was a problem hiding this comment.
"vDC" -> "VDC" (also in the rest of the PR)
Signed-off-by: Vaidotas Bauzys <[email protected]>
Signed-off-by: Vaidotas Bauzys <[email protected]>
Signed-off-by: Vaidotas Bauzys <[email protected]>
Signed-off-by: Vaidotas Bauzys <[email protected]>
Signed-off-by: Vaidotas Bauzys <[email protected]>
Signed-off-by: Vaidotas Bauzys <[email protected]>
Didainius
reviewed
Jul 3, 2019
Didainius
reviewed
Jul 3, 2019
Signed-off-by: Vaidotas Bauzys <[email protected]>
Didainius
approved these changes
Jul 3, 2019
Signed-off-by: Vaidotas Bauzys <[email protected]>
lvirbalas
requested changes
Jul 3, 2019
CHANGELOG.md
Outdated
|
|
||
| IMPROVEMENTS: | ||
| * Fix ignoring of resource guarantee values in `vcd_org_vdc` [GH-265] | ||
| * **Resource:** Org VDC `vcd_org_vdc` ID changed from name to vCD ID - [GH-275] |
There was a problem hiding this comment.
**Resource:** highlight shouldn't be needed here. Unless I missed it, in guidelines there's no emphasis on improvements. They suggest using a form like this instead:
IMPROVEMENTS:
* resource/load_balancer: Add `ATTRIBUTE` argument (support X new functionality) [GH-12]
* resource/subnet: Now better [GH-22, GH-32]
Signed-off-by: Vaidotas Bauzys <[email protected]>
Signed-off-by: Vaidotas Bauzys <[email protected]>
Signed-off-by: Vaidotas Bauzys <[email protected]>
Signed-off-by: Vaidotas Bauzys <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref:
https://github.com/terraform-providers/terraform-provider-vcd/issues/222
https://github.com/terraform-providers/terraform-provider-vcd/issues/239
https://github.com/terraform-providers/terraform-provider-vcd/issues/237
https://github.com/terraform-providers/terraform-provider-vcd/issues/265
These changes fix bug where resources guarantee were ignored on serializing, allows Org VDC update to be udpated and read fills and refresh all data in state file, state ID changed from name to vCD resource ID.