Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add load balancer server pool resource and datasource #268

Merged
merged 62 commits into from
Jul 1, 2019
Merged

Add load balancer server pool resource and datasource #268

merged 62 commits into from
Jul 1, 2019

Conversation

Didainius
Copy link
Collaborator

As part of #223 this PR introduces load balancer server pool resource and datasource.

Didainius added 30 commits June 7, 2019 13:46
@Didainius
Add load balancer service monitor resource and datasource
1b89ecb
@Didainius
Add misc test, more adjustments
14cfc76
@Didainius
rebase ant start using real locks
cff09d4
@Didainius
Bump govcd dependency
6e81383
@Didainius
Adjust validations and tests
5ba7ec4
@Didainius
Update gitignore to ommit .vscode
1efd324
@Didainius
Cleanup old comments
5bec871
@Didainius
Add sample for expandLBMonitor
7b43f23
@Didainius
call flattenLBMonitor on update return
562ff84
@Didainius
Improve names, fmt sample snippet
a1f12fa
@Didainius
Lowercase function name
7ca3aad
@Didainius
Add options list for method
bc9c783
@Didainius
Add url parameter to test and examples
4e988ac
@Didainius
Add names to description, unify case checking function
b982cc0
@Didainius
change import name in examples
c947c70
@Didainius
health -> /health
385ffec
@Didainius
bump govcd dependency
9b44d3a
@Didainius
bump govcd dependency
a3b842f
@Didainius
bump dependency after govcd rebase
eedeb83
@Didainius
Rename flatten/expand functions
1335d75
@Didainius
bump govcd, add note for requirement of advanced edge gw
446b02a
@Didainius
Bump dependency to master branch
6270aa7
@Didainius
Add website import note, show units for interval
ea070cb
@Didainius
Address comments
0ee1c4e
@Didainius
Add descriptions for non-computed fields in datasource
179179b
@Didainius
Add load balancer service monitor resource and datasource
153274e
@Didainius
WIP
4c7700c
@Didainius
works with TypeSet
5ae1dc9
@Didainius
Add test
9b59156
@Didainius
Add import test
3bd1ea9
dataclouder
dataclouder suggested changes Jun 26, 2019
View reviewed changes
Copy link
Contributor

@dataclouder dataclouder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preliminary review

@dataclouder
Copy link
Contributor

One thing is missing for the tests: config_test.go should also have tags lb and lbServerPool

@Didainius
Copy link
Collaborator Author

One thing is missing for the tests: config_test.go should also have tags lb and lbServerPool

Added. As well lbServiceMonitor.

dataclouder
dataclouder approved these changes Jun 26, 2019
View reviewed changes
Copy link
Contributor

@dataclouder dataclouder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lvirbalas
lvirbalas approved these changes Jun 27, 2019
View reviewed changes
Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the improvements!

@vbauzys
Copy link
Contributor

vbauzys commented Jun 28, 2019

Conflicts needs to be solved

vbauzys
vbauzys reviewed Jun 28, 2019
View reviewed changes
Copy link
Contributor

@vbauzys vbauzys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small things to improve

vcd/resource_vcd_lb_server_pool.go Show resolved Hide resolved
vcd/resource_vcd_lb_server_pool.go Show resolved Hide resolved
website/docs/r/lb_server_pool.html.markdown Show resolved Hide resolved
@Didainius
Copy link
Collaborator Author

Conflicts needs to be solved

Resolved.

vbauzys
vbauzys approved these changes Jul 1, 2019
View reviewed changes
Copy link
Contributor

@vbauzys vbauzys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Didainius Didainius self-assigned this Jul 1, 2019
@Didainius Didainius merged commit 7a4aa9b into vmware:master Jul 1, 2019
@Didainius Didainius deleted the lb222 branch July 1, 2019 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbauzys vbauzys vbauzys approved these changes

@dataclouder dataclouder dataclouder approved these changes

@lvirbalas lvirbalas lvirbalas approved these changes

Assignees

@Didainius Didainius

Labels
dependencies documentation size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Didainius @dataclouder @vbauzys @lvirbalas