fix typo that undeploys vapp instead of vm while deleting a vm #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Nice catch, still we need to investigate how it related to |
|
If everyone would approve I suggest together with this fix remove 873-894 case. I don't see any more value for deploy if don't undepoy vAPP. My testing seem to verify that. I would like other to verify that. |
dataclouder
approved these changes
Jun 14, 2019
Didainius
approved these changes
Jun 26, 2019
There was a problem hiding this comment.
@vkhacharia, thank you for this PR.
Can you add a message to CHANGELOG under IMPROVEMENTS section and let's merge it.
|
Do I update the changelog and make new pull request? |
|
@vkhacharia NP, I will put in a note with the next PR I have in the oven :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found the pointer in #69 Updated the code and tested locally.