Add load balancer service monitor resource and datasource #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
lvirbalas
reviewed
Jun 5, 2019
Didainius
commented
Jun 10, 2019
vbauzys
suggested changes
Jun 11, 2019
vbauzys
reviewed
Jun 11, 2019
lvirbalas
reviewed
Jun 11, 2019
| edge_gateway = "my-edge-gw" | ||
|
|
||
| name = "not-managed" | ||
| } |
There was a problem hiding this comment.
What about expanding example to not only show how to define this datasource, but also how to use it in some other resource?
There was a problem hiding this comment.
We can, but not yet. The next resource later on (vcd_lb_server_pool) will be able to consume it. Nothing else can use it now.
There was a problem hiding this comment.
Thanks, would be great to have that when possible.
lvirbalas
reviewed
Jun 13, 2019
lvirbalas
requested changes
Jun 13, 2019
| edge_gateway = "my-edge-gw" | ||
|
|
||
| name = "not-managed" | ||
| } |
There was a problem hiding this comment.
Thanks, would be great to have that when possible.
dataclouder
suggested changes
Jun 14, 2019
lvirbalas
approved these changes
Jun 14, 2019
dataclouder
reviewed
Jun 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #223
Note Because load balancers depend on edge gateway having none other operations this PR will adopt locking functionality introduced in #255 before merge once it is in master.This is the first PR to start supporting edge gateway load balancers.
It includes resource and datasource
vcd_lb_service_monitor. All actions should be possible includingimport.