Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mutex change #255

Merged
merged 33 commits into from
Jun 7, 2019
Merged

Mutex change #255

merged 33 commits into from
Jun 7, 2019

Conversation

vbauzys
Copy link
Contributor

@vbauzys vbauzys commented May 31, 2019

This initial change which allows us come from retrycall approach to mutex one.

Notes:

  • Remove rectrycall's
  • Add k,v mutex
  • Add locking/unlocking helper functions
  • remove locking where isn't needed - now isolated/direct networks works faster

Spotted issues:

  • for a moment vm.changeName fails without rectrycall - looks like function initiated to soon, though vm creation task completed
  • Test TestAccVcdVApp_PowerOff failing on my env. Seems that in test's terraform dependencies isn't working - if HCL runned with binary - everything is fine. Still looking for solution

@vbauzys
Add initial Mutex change
cb6e118 
Signed-off-by: Vaidotas Bauzys <[email protected]>
@ghost ghost added the size/XL label May 31, 2019
@vbauzys vbauzys requested review from Didainius, lvirbalas and dataclouder and removed request for Didainius and lvirbalas May 31, 2019 13:26
@vbauzys vbauzys self-assigned this May 31, 2019
@vbauzys vbauzys requested a review from lvirbalas May 31, 2019 13:26
Didainius
Didainius reviewed Jun 3, 2019
View reviewed changes
Copy link
Collaborator

@Didainius Didainius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So happy to see getting rid of the retry calls :) 🥇 🙇
This is round one and I'm going for further testing and second review.

vcd/provider.go Outdated Show resolved Hide resolved
vcd/resource_vcd_network_direct.go Show resolved Hide resolved
vcd/resource_vcd_network_routed.go Outdated Show resolved Hide resolved
vcd/resource_vcd_snat.go Outdated Show resolved Hide resolved
vcd/resource_vcd_vapp.go Show resolved Hide resolved
vcd/provider.go Outdated Show resolved Hide resolved
dataclouder
dataclouder reviewed Jun 3, 2019
View reviewed changes
vcd/provider.go Outdated Show resolved Hide resolved
lvirbalas
lvirbalas reviewed Jun 3, 2019
View reviewed changes
Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add an antry in CHANGELOG.md for this feature.

vcd/provider.go Outdated Show resolved Hide resolved
vcd/provider.go Outdated Show resolved Hide resolved
@Didainius Didainius mentioned this pull request Jun 3, 2019
Merged
vbauzys added 3 commits June 3, 2019 13:45
@vbauzys
Improvements
5dd310c 
Signed-off-by: Vaidotas Bauzys <[email protected]>
@vbauzys
Improvements
72816cd 
Signed-off-by: Vaidotas Bauzys <[email protected]>
@vbauzys
Added logging and improved key construction
5d13a51 
Signed-off-by: Vaidotas Bauzys <[email protected]>
dataclouder
dataclouder reviewed Jun 3, 2019
View reviewed changes
vcd/provider.go Outdated Show resolved Hide resolved
dataclouder
dataclouder reviewed Jun 3, 2019
View reviewed changes
vcd/provider.go Outdated Show resolved Hide resolved
vbauzys added 2 commits June 3, 2019 15:02
@vbauzys
Added lock for vm update
e754201 
Signed-off-by: Vaidotas Bauzys <[email protected]>
@vbauzys
Improve imports
fb8ec5f 
Signed-off-by: Vaidotas Bauzys <[email protected]>
lvirbalas
lvirbalas requested changes Jun 3, 2019
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
vcd/provider.go Outdated Show resolved Hide resolved
vcd/resource_vcd_network_routed.go Outdated Show resolved Hide resolved
@ghost ghost added size/XXL and removed size/XL labels Jun 7, 2019
@vbauzys
Copy link
Contributor Author

vbauzys commented Jun 7, 2019

resource_vcd_vapp_vm.g

Comment updated to moved to better place

dataclouder
dataclouder reviewed Jun 7, 2019
View reviewed changes
vcd/config.go Outdated Show resolved Hide resolved
dataclouder
dataclouder reviewed Jun 7, 2019
View reviewed changes
vcd/config.go Outdated Show resolved Hide resolved
vbauzys added 2 commits June 7, 2019 12:08
@vbauzys
Improved error messages
63430f8 
Signed-off-by: Vaidotas Bauzys <[email protected]>
@vbauzys
Improved error messages
94bb963 
Signed-off-by: Vaidotas Bauzys <[email protected]>
dataclouder
dataclouder approved these changes Jun 7, 2019
View reviewed changes
Copy link
Contributor

@dataclouder dataclouder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lvirbalas
lvirbalas approved these changes Jun 7, 2019
View reviewed changes
Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do it!

@vbauzys vbauzys merged commit 21ec5fd into vmware:master Jun 7, 2019
@lvirbalas lvirbalas mentioned this pull request Jun 7, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Didainius Didainius Didainius approved these changes

@dataclouder dataclouder dataclouder approved these changes

@lvirbalas lvirbalas lvirbalas approved these changes

Assignees

@vbauzys vbauzys

Labels
dependencies size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vbauzys @Didainius @lvirbalas @dataclouder