Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PROPOSAL] Switch to Go Modules #135

Closed
appilon opened this issue Feb 4, 2019 · 2 comments
Closed

[PROPOSAL] Switch to Go Modules #135

appilon opened this issue Feb 4, 2019 · 2 comments

Comments

@appilon
Copy link
Contributor

appilon commented Feb 4, 2019

As part of the preparation for Terraform v0.12, we would like to migrate all providers to use Go Modules. We plan to continue checking dependencies into vendor/ to remain compatible with existing tooling/CI for a period of time, however go modules will be used for management. Go Modules is the official solution for the go programming language, we understand some providers might not want this change yet, however we encourage providers to begin looking towards the switch as this is how we will be managing all Go projects in the future. Would maintainers please react with 👍 for support, or 👎 if you wish to have this provider omitted from the first wave of pull requests. If your provider is in support, we would ask that you avoid merging any pull requests that mutate the dependencies while the Go Modules PR is open (in fact a total codefreeze would be even more helpful), otherwise we will need to close that PR and re-run go mod init. Once merged, dependencies can be added or updated as follows:

$ GO111MODULE=on go get github.com/some/module@master
$ GO111MODULE=on go mod tidy
$ GO111MODULE=on go mod vendor

GO111MODULE=on might be unnecessary depending on your environment, this example will fetch a module @ master and record it in your project's go.mod and go.sum files. It's a good idea to tidy up afterward and then copy the dependencies into vendor/. To remove dependencies from your project, simply remove all usage from your codebase and run:

$ GO111MODULE=on go mody tidy
$ GO111MODULE=on go mod vendor

Thank you sincerely for all your time, contributions, and cooperation!

@bill-rich
Copy link

Hi @annakhm! Is there anything I can do to help get switched over to Go modules? We're coming up on the Terraform 0.12 release, and trying to get provider support covered. If you can provide some more information on what is blocking the switch, maybe I can provide some extra support. Thanks!

@annakhm
Copy link
Collaborator

annakhm commented Feb 27, 2019

hi @bill-rich, now when new provider version is released and @radeksimko explained a bit more about go modules, we are in a better to place to switch. We are stabilizing the failing tests as well, which should help with the transition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants