This repository has been archived by the owner on Nov 16, 2020. It is now read-only.
Add switchable contexts for config #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
berndtj
commented
May 25, 2018
berndtj
commented
- keep map of configurations with one current context
- list contexts (highlight current)
- set current
- push the certificate chart
berndtj
force-pushed
the
contexts
branch
6 times, most recently
from
73e7024
to
e416df7
Compare
tenczar
previously approved these changes
May 25, 2018
neosab
previously approved these changes
May 25, 2018
| @@ -34,13 +34,13 @@ var ( | |||
|
|
|||
| manageExample = i18n.T(` | |||
| # Enable Dispatch bootstrap mode while specifying bootstrap user | |||
| dispatch manage --enable-bootstrap-mode --bootstrap-user [email protected] -f ./config.yaml | |||
There was a problem hiding this comment.
I think we should move the enable/disable bootstrap flags to their own subcommands in another PR.
* keep map of configurations with one current context * list contexts (highlight current) * set current * push the certificate chart
neosab
approved these changes
May 25, 2018
markpeek
reviewed
May 26, 2018
There was a problem hiding this comment.
I like where this is headed but some enhancements would be good.
- There should be a module to handle the initialization, unmarshalling, get/set context in common functions.
- Allow for a --config or environment variable to override the current context.
- A way to easily add and remove a context via CLI.
- Have common code/error messages for attempting to add over an existing context name or deleting a non-existent context.
- cmdConfig => cmdContexts?
|
I agree @markpeek, this was a bit quick and dirty and also not meant to be the "full" solution. We can iterate on it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.