Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Linux] update get_system_firmware.yml to get system firmware for FreeBSD #567

Merged
merged 2 commits into from
Apr 1, 2024

Conversation

keirazhang
Copy link
Contributor

FreeBSD doesn't have /sys/firmware/efi, but can check efirt is loaded if system firmware is EFI. So, this fix is to set guest_firmware for FreeBSD.

Test passed:

+----------------------------------------------------------+
| GuestInfo Detailed Data   | architecture='X86'           |
|                           | bitness='64'                 |
|                           | distroName='FreeBSD'         |
|                           | familyName='FreeBSD'         |
|                           | kernelVersion='13.3-RELEASE' |
+----------------------------------------------------------+


Test Results (Total: 1, Passed: 1, Elapsed Time: 00:01:10)
+----------------------------------------------+
| ID | Name               | Status | Exec Time |
+----------------------------------------------+
|  1 | check_efi_firmware | Passed | 00:00:52  |
+----------------------------------------------+

@keirazhang keirazhang added this to the 3.2 milestone Apr 1, 2024
Copy link
Member

@Tomorrow9 Tomorrow9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@keirazhang keirazhang merged commit 6f9bd27 into vmware:main Apr 1, 2024
@keirazhang keirazhang deleted the fix_freebsd_firmware branch June 24, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants