Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Windows] Fix incorrect user and sysprep error in GOSC test cases #519

Merged
merged 5 commits into from
Dec 18, 2023
Merged

[Windows] Fix incorrect user and sysprep error in GOSC test cases #519

merged 5 commits into from
Dec 18, 2023

Conversation

Tomorrow9
Copy link
Member

@Tomorrow9 Tomorrow9 commented Nov 28, 2023 •
edited
Loading

  1. Change to use the configured vm_username to fetch files from guest OS since customized user 'Administrator' maybe not available due to GOSC failure.
  2. Change to use a common file win_gosc_workflow.yml as Linux test case to avoid duplicated tasks.
  3. Fix sysprep failure by removing packages reported.

@Tomorrow9 Tomorrow9 added this to the 3.1 milestone Nov 28, 2023
keirazhang
keirazhang previously approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@keirazhang keirazhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@Tomorrow9 Tomorrow9 changed the title [Windows] Fix incorrect user error in test case gosc_sanity_staticip [Windows] Fix incorrect user and sysprep error in test case gosc_sanity_staticip Dec 12, 2023
@Tomorrow9 Tomorrow9 changed the title [Windows] Fix incorrect user and sysprep error in test case gosc_sanity_staticip [Windows] Fix incorrect user and sysprep error in GOSC test cases Dec 12, 2023
123lzxm
123lzxm reviewed Dec 12, 2023
View reviewed changes
windows/guest_customization/gosc_sanity_dhcp.yml Outdated Show resolved Hide resolved
windows/guest_customization/gosc_sanity_dhcp.yml Outdated Show resolved Hide resolved
windows/guest_customization/gosc_sanity_staticip.yml Outdated Show resolved Hide resolved
windows/guest_customization/gosc_sanity_staticip.yml Outdated Show resolved Hide resolved
windows/guest_customization/win_gosc_prepare.yml Outdated Show resolved Hide resolved
windows/guest_customization/check_autologon_count.yml Outdated Show resolved Hide resolved
@Tomorrow9
fix incorrect user error
7464353 
Signed-off-by: Diane Wang <[email protected]>
@Tomorrow9
restructure test case
5328122 
Signed-off-by: Diane Wang <[email protected]>
@Tomorrow9
add remove appx package
5b4eb8b 
Signed-off-by: Diane Wang <[email protected]>
@Tomorrow9
address issues
a766e07 
Signed-off-by: Diane Wang <[email protected]>
@Tomorrow9
address comments
f67b99a 
Signed-off-by: Diane Wang <[email protected]>
keirazhang
keirazhang approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@keirazhang keirazhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

123lzxm
123lzxm approved these changes Dec 18, 2023
View reviewed changes
Copy link
Collaborator

@123lzxm 123lzxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@Tomorrow9 Tomorrow9 merged commit 7d59aa6 into vmware:main Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@123lzxm 123lzxm 123lzxm approved these changes

@keirazhang keirazhang keirazhang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.
3 participants
@Tomorrow9 @keirazhang @123lzxm