Set VM primary NIC MAC address at env_setup or deploy_vm #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tomorrow9
reviewed
Apr 10, 2023
Signed-off-by: Qi Zhang <[email protected]>
Signed-off-by: Qi Zhang <[email protected]>
…from_vmtools.yml Signed-off-by: Qi Zhang <[email protected]>
keirazhang
force-pushed
the
fix_primary_nic
branch
from
6961b5b
to
21200e2
Compare
Signed-off-by: Qi Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a limitation about testing VM must have only 1 network adapter and it should be connected. That means we can get VM's primary NIC at env_setup for existing VM or deploy_vm for new VM. So it can simplify the process of getting VM guest IP of the primary NIC. Files
vm_get_primary_nic.ymlandvm_test_nic.ymlcan be removed.