Add controller name to periodical_enqueue_source #8198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaovilai
force-pushed
the
pes-controller
branch
from
24f33e6
to
2b3ea39
Compare
|
/kind changelog-not-required |
github-actions
bot
added
the
kind/changelog-not-required
kaovilai
force-pushed
the
pes-controller
branch
3 times, most recently
from
f2f03e6
to
84ec3e5
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8198 +/- ##
==========================================
- Coverage 59.23% 59.19% -0.04%
==========================================
Files 367 367
Lines 30516 30730 +214
==========================================
+ Hits 18076 18191 +115
- Misses 10985 11085 +100
+ Partials 1455 1454 -1 ☔ View full report in Codecov by Sentry. |
The code changes are related to the `NewPeriodicalEnqueueSource` function in the `kube/periodical_enqueue_source.go` file. This function is used to create a new instance of the `PeriodicalEnqueueSource` struct, which is responsible for periodically enqueueing objects into a work queue. The changes involve adding two new parameters to this function: `controllerName string` and modifying the existing `logger` parameter to include additional fields. Here's what changed: 1. A new `controllerName` parameter was added to the `NewPeriodicalEnqueueSource` function. These changes are to adding more context or metadata to the logging output, possibly for debugging or monitoring purposes. The other files (`restore_operations_controller.go`, `schedule_controller.go`, and their respective test files) were modified to use this updated `NewPeriodicalEnqueueSource` function with the new `controllerName` parameter. Signed-off-by: Tiger Kaovilai <[email protected]>
kaovilai
force-pushed
the
pes-controller
branch
from
84ec3e5
to
5c4c66b
Compare
sseago
previously approved these changes
Sep 9, 2024
shubham-pampattiwar
previously approved these changes
Sep 9, 2024
ywk253100
reviewed
Sep 10, 2024
Signed-off-by: Tiger Kaovilai <[email protected]>
kaovilai
dismissed stale reviews from shubham-pampattiwar and sseago
via
c8aa37d
sseago
approved these changes
Sep 12, 2024
ywk253100
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code changes are related to the
NewPeriodicalEnqueueSourcefunction in thekube/periodical_enqueue_source.gofile. This function is used to create a new instance of thePeriodicalEnqueueSourcestruct, which is responsible for periodically enqueueing objects into a work queue.The changes involve adding two new parameters to this function:
controllerName stringand modifying the existingloggerparameter to include additional fields.Here's what changed:
controllerNameparameter was added to theNewPeriodicalEnqueueSourcefunction.loggerparameter now includes an additional field with the value ofreflect.TypeOf(objList).String()and another field with the value ofcontrollerName.These changes are to adding more context or metadata to the logging output, possibly for debugging or monitoring purposes.
The other files (
restore_operations_controller.go,schedule_controller.go, and their respective test files) were modified to use this updatedNewPeriodicalEnqueueSourcefunction with the newcontrollerNameparameter.Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #(issue)
Please indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.