-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data mover micro service backup #8046
Data mover micro service backup #8046
Conversation
0e6f39e
to
15ad51e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8046 +/- ##
==========================================
+ Coverage 58.88% 58.91% +0.02%
==========================================
Files 351 353 +2
Lines 29367 29643 +276
==========================================
+ Hits 17294 17464 +170
- Misses 10639 10738 +99
- Partials 1434 1441 +7 ☔ View full report in Codecov by Sentry. |
3a04527
to
0786dbc
Compare
Signed-off-by: Lyndon-Li <[email protected]>
0786dbc
to
8742f1b
Compare
Signed-off-by: Lyndon-Li <[email protected]>
return nil, errors.Wrap(err, "error to create client config") | ||
} | ||
|
||
ctrl.SetLogger(zap.New(zap.UseDevMode(true))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems this line is not relevant to the context.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me check this separately since this code is same with the node-agent server.
If there is any problem, I will modify it for both here and the node-agent server in a separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After a preliminary check, this is basically OK.
zap.New(zap.UseDevMode(true))also initializes a logger to
stderrwhich is the same with
logger logrus.FieldLoggerand the default log level is
Info. Merely,
logger logrus.FieldLoggeris with more info about the log level and format, but
zap.New(zap.UseDevMode(true))may not comply with them. We probably seldomly need the logs from controller-runtime to be in
debug` level.
The same code in the node-agent server was introduced in this PR #2561. Since it is an old one, we don't know any other special reason for not using the provided logger.
Therefore, I suggest we keep it as is until we see problems, then we come back to change all the places the same as here.
Data mover micro service backup according to design #7576