Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid wrapping failed PVB status with empty message. #8028

Merged
merged 2 commits into from
Jul 22, 2024

Conversation

mrnold
Copy link
Contributor

@mrnold mrnold commented Jul 18, 2024

Please add a summary of your change

This change removes a leading ':' character in the status message of a failed PVB, and changes "get" to "found". For example, from:
: get a podvolumebackup with status "InProgress" during the server starting, mark it as "Failed"
to:
found a podvolumebackup with status "InProgress" during the server starting, mark it as "Failed"

Does your change fix a particular issue?

Fixes #7857

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

Also change "get" to "found" as requested in issue vmware-tanzu#7857.

Signed-off-by: Matthew Arnold <[email protected]>
Signed-off-by: Matthew Arnold <[email protected]>
Copy link

codecov bot commented Jul 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 58.82%. Comparing base (55e0278) to head (f8e697d).
Report is 7 commits behind head on main.

Files Patch % Lines
pkg/controller/pod_volume_backup_controller.go 0.00% 4 Missing ⚠️
pkg/cmd/cli/nodeagent/server.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8028      +/-   ##
==========================================
- Coverage   58.82%   58.82%   -0.01%     
==========================================
  Files         346      346              
  Lines       28886    28889       +3     
==========================================
  Hits        16993    16993              
- Misses      10464    10467       +3     
  Partials     1429     1429              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ywk253100 ywk253100 merged commit 84feddb into vmware-tanzu:main Jul 22, 2024
64 of 66 checks passed
mrnold pushed a commit to mrnold/velero that referenced this pull request Jul 22, 2024
Avoid wrapping failed PVB status with empty message.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PodVolumeBackup CR status.message field has an extra colon, also the get word can be replaced with found.
6 participants