Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data mover restore enhancement for WaitForFirstConsumer volume #8044

Closed
Lyndon-Li opened this issue Jul 24, 2024 · 2 comments
Closed

Data mover restore enhancement for WaitForFirstConsumer volume #8044

Lyndon-Li opened this issue Jul 24, 2024 · 2 comments
Assignees
Milestone

Comments

@Lyndon-Li
Copy link
Contributor

For a WaitForFirstConsumer volume, the PV should not be provisioned until the pod consuming it is scheduled. This conflicts with the generic restore process for data mover.
As the current behavior, the generic restore always wait there until the pod to be restored is scheduled.

This is good enough to make the generic restore works appropriately with WaitForFirstConsumer volumes, but it has some drawbacks:

  1. This couples the data mover restore with the resource restore (workload pod restore), if the pod is not scheduled for any reason, the data mover restore will get wait timeout and fail
  2. This doesn't allow the data mover restore to support restoring PVC/PV only without pod. While it is already supported for Immediate volumes

Actually, users must know their topology constrains if they have that, or they must know in which nodes their restored workload pods can be scheduled.
Therefore, we can add a parameter for each volume to be restored for users to specify the candidate nodes. Consequently, generic restore will not wait for the workload pod to be scheduled and get the node, but use the candidate nodes to schedule the restorePod.

Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days. If a Velero team member has requested log or more information, please provide the output of the shared commands.

@sseago
Copy link
Collaborator

sseago commented Sep 23, 2024

not stale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants