Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore from datamover backup returns completed result although CSI plugin is not provided during backup phase #6693

Closed
danfengliu opened this issue Aug 23, 2023 · 4 comments

Comments

@danfengliu
Copy link
Contributor

danfengliu commented Aug 23, 2023

What steps did you take and what happened:
Install Velero without CSI plugin provided, and backup some workload with PVs using datamover flag and EnableCSI flag, then restore from the backup and returns completed result, but PV data is not restored.

What did you expect to happen:
In this case, since it's not backed up by any backup mechanism, restore result should be PartiallyFailed to notify users.

The following information will help us better understand what's going on:

If you are using velero v1.7.0+:
Please use velero debug --backup <backupname> --restore <restorename> to generate the support bundle, and attach to this issue, more options please refer to velero debug --help

If you are using earlier versions:
Please provide the output of the following commands (Pasting long output into a GitHub gist or other pastebin is fine.)

  • kubectl logs deployment/velero -n velero
  • velero backup describe <backupname> or kubectl get backup/<backupname> -n velero -o yaml
  • velero backup logs <backupname>
  • velero restore describe <restorename> or kubectl get restore/<restorename> -n velero -o yaml
  • velero restore logs <restorename>

Anything else you would like to add:

Environment:

  • Velero version (use velero version):
  • Velero features (use velero client config get features):
  • Kubernetes version (use kubectl version):
  • Kubernetes installer & version:
  • Cloud provider or hardware configuration:
  • OS (e.g. from /etc/os-release):

Vote on this issue!

This is an invitation to the Velero community to vote on issues, you can see the project's top voted issues listed here.
Use the "reaction smiley face" up to the right of this comment to vote.

  • 👍 for "I would like to see this bug fixed as soon as possible"
  • 👎 for "There are more important bugs to focus on right now"
@Lyndon-Li Lyndon-Li added the 1.13-candidate issue/pr that should be considered to target v1.13 minor release label Aug 23, 2023
@Lyndon-Li
Copy link
Contributor

This issue may need to work together with #6595, the both issues need a way to identify volumes backed by CSI volume snapshot (with or without data mover) in Velero restore workflow.

@reasonerjt reasonerjt added Reviewed Q3 2023 Needs info Waiting for information labels Aug 30, 2023
@reasonerjt
Copy link
Contributor

Clarification needed for priority of this issue.

@reasonerjt reasonerjt added pv-backup-info and removed target/1.12.1 Needs info Waiting for information labels Sep 20, 2023
@reasonerjt
Copy link
Contributor

This will depends on the metadata about volumes mentioned in
#6695 (comment)

@reasonerjt reasonerjt removed the 1.13-candidate issue/pr that should be considered to target v1.13 minor release label Oct 18, 2023
@reasonerjt reasonerjt added this to the v1.13 milestone Oct 18, 2023
@danfengliu danfengliu changed the title Restore from datamover backup returns completed result although CSI plugin is not provided Restore from datamover backup returns completed result although CSI plugin is not provided during backup phase Nov 8, 2023
@Lyndon-Li
Copy link
Contributor

Fixed by #7077

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants