Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add velero_backup_warning_total metric #5380

Closed
varac opened this issue Sep 22, 2022 · 0 comments · Fixed by #5779
Closed

Add velero_backup_warning_total metric #5380

varac opened this issue Sep 22, 2022 · 0 comments · Fixed by #5779
Assignees
Labels
kind/requirement Metrics Related to prometheus metrics
Milestone

Comments

@varac
Copy link

varac commented Sep 22, 2022

Describe the problem/challenge you have

The current prometheus exporter doesn't alert when there are warnings in backup sets. I.e. this backup had a warning because it could not find the wordpress-wp-uploads volume, because it was renamed (rather serious i.m.o.):

❯ velero get backup                                            
NAME                          STATUS      ERRORS   WARNINGS   CREATED                          EXPIRES   STORAGE LOCATION   SELECTOR
velero-daily-20220908033056   Completed   0        1          2022-09-08 05:30:56 +0200 CEST   14d       default            <none>
...

❯ velero backup logs velero-daily-20220908033056 | grep -i warn
time="2022-09-08T03:31:36Z" level=warning msg="No volume named wordpress-wp-uploads found in pod stackspin-apps/wordpress-0, skipping" backup=velero/velero-daily-20220908033056 logSource="pkg/restic/backupper.go:143" name=wordpress-0 namespace=stackspin-apps resource=pods

But the velero exporter still shows velero_backup_failure_total as 0.

Describe the solution you'd like

I'd like to propose an additional metric called velero_backup_warning_total.

Environment:

  • Velero version (use velero version) : Client: v1.9.1, Server: Version: v1.9.1
  • Kubernetes version (use kubectl version): v1.24.4
  • Kubernetes installer & version: k3s v1.24.4+k3s1
  • OS (e.g. from /etc/os-release): Server: Debian bullseye

Vote on this issue!

This is an invitation to the Velero community to vote on issues, you can see the project's top voted issues listed here.
Use the "reaction smiley face" up to the right of this comment to vote.

  • 👍 for "The project would be better with this feature added"
  • 👎 for "This feature will not enhance the project in a meaningful way"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/requirement Metrics Related to prometheus metrics
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants