-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --plugins flag to velero install
to allow plugins to be included at install time
#1740
Comments
xref #1537 |
IMO, the values for |
This would be great as it would open the path to support this with the helm chart and to have a declarative / terraform compatible way of managing those plugins. |
But actually it's 2 distinct paths given the helm chart is not invoking the cli to install velero... I should open a separate issue to track this. |
An issue for the Helm change was created: #1819 |
Per discussion with the team, we're going to, for the time being, make installation a 2 step process - running This is mostly temporary to get things split up per #1870. Longer term, we want to revisit how plugins are handled holistically so we have a clearer answer for how things like secrets may be handled, and the possibility of making plugins run as sidecars instead of init containers. |
What's the reasoning for not adding the flag to I'm fine revisiting things down the road, but I'm failing to see how making it a separate step right now is better than this. |
This came up as confusing during one of our discussions on the implementations. A 2 step process was proposed, one for getting the resources into the cluster and one for installing the plugins. That's possible today. I'm fine with adding the |
It's fine by me. |
To be clear, I definitely think there's room for improvement here in the install & setup flow, the relationships between plugin images, names, and BSLs/VSLs, what we validate at server startup, etc. that we should take a holistic look at - but I propose doing that separately. |
velero install
should allow 1+ plugins to be installed during the main install process. This would allow out-of-tree cloud providers and other plugins to be installed seamlessly, without requiring a restart.The text was updated successfully, but these errors were encountered: