From 2aaa85bc5830ef9ef8b81be5db6eae6fa310056b Mon Sep 17 00:00:00 2001 From: Shubham Pampattiwar Date: Mon, 22 May 2023 14:36:25 -0700 Subject: [PATCH] add default values for defaultItemOperationTimeout and itemOperationSyncFrequency in velero CLI Signed-off-by: Shubham Pampattiwar add changelog Signed-off-by: Shubham Pampattiwar update default value for itemOperationsSyncFrequency Signed-off-by: Shubham Pampattiwar --- changelogs/unreleased/6298-shubham-pampattiwar | 1 + pkg/cmd/server/server.go | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) create mode 100644 changelogs/unreleased/6298-shubham-pampattiwar diff --git a/changelogs/unreleased/6298-shubham-pampattiwar b/changelogs/unreleased/6298-shubham-pampattiwar new file mode 100644 index 0000000000..3784d1e024 --- /dev/null +++ b/changelogs/unreleased/6298-shubham-pampattiwar @@ -0,0 +1 @@ +Add default values for defaultItemOperationTimeout and itemOperationSyncFrequency in velero CLI \ No newline at end of file diff --git a/pkg/cmd/server/server.go b/pkg/cmd/server/server.go index ec108536ec..e067283307 100644 --- a/pkg/cmd/server/server.go +++ b/pkg/cmd/server/server.go @@ -226,10 +226,10 @@ func NewCommand(f client.Factory) *cobra.Command { command.Flags().DurationVar(&config.defaultBackupTTL, "default-backup-ttl", config.defaultBackupTTL, "How long to wait by default before backups can be garbage collected.") command.Flags().DurationVar(&config.repoMaintenanceFrequency, "default-repo-maintain-frequency", config.repoMaintenanceFrequency, "How often 'maintain' is run for backup repositories by default.") command.Flags().DurationVar(&config.garbageCollectionFrequency, "garbage-collection-frequency", config.garbageCollectionFrequency, "How often garbage collection is run for expired backups.") - command.Flags().DurationVar(&config.itemOperationSyncFrequency, "item-operation-sync-frequency", config.itemOperationSyncFrequency, "How often to check status on backup/restore operations after backup/restore processing.") + command.Flags().DurationVar(&config.itemOperationSyncFrequency, "item-operation-sync-frequency", config.itemOperationSyncFrequency, "How often to check status on backup/restore operations after backup/restore processing. Default is 10 seconds") command.Flags().BoolVar(&config.defaultVolumesToFsBackup, "default-volumes-to-fs-backup", config.defaultVolumesToFsBackup, "Backup all volumes with pod volume file system backup by default.") command.Flags().StringVar(&config.uploaderType, "uploader-type", config.uploaderType, "Type of uploader to handle the transfer of data of pod volumes") - command.Flags().DurationVar(&config.defaultItemOperationTimeout, "default-item-operation-timeout", config.defaultItemOperationTimeout, "How long to wait on asynchronous BackupItemActions and RestoreItemActions to complete before timing out.") + command.Flags().DurationVar(&config.defaultItemOperationTimeout, "default-item-operation-timeout", config.defaultItemOperationTimeout, "How long to wait on asynchronous BackupItemActions and RestoreItemActions to complete before timing out. Default is 1 hour") command.Flags().DurationVar(&config.resourceTimeout, "resource-timeout", config.resourceTimeout, "How long to wait for resource processes which are not covered by other specific timeout parameters. Default is 10 minutes.") command.Flags().IntVar(&config.maxConcurrentK8SConnections, "max-concurrent-k8s-connections", config.maxConcurrentK8SConnections, "Max concurrent connections number that Velero can create with kube-apiserver. Default is 30.")