Allow plugins to be specified via a URL #989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure why but the 2 circleci checks are hung; they seemed to have pass but just not get reported to Github |
zubron
reviewed
Nov 11, 2019
|
|
||
| newPlugin, err := loadManifest(b) | ||
| if err != nil { | ||
| return errors.Wrapf(err, "failed to load plugin file %q", filepath) | ||
| return errors.Wrap(err, "failed to load plugin") |
There was a problem hiding this comment.
Minor usability nit: If the user specifies multiple plugins and one fails to decode, it seems like it won't be as easy to determine which one had the issue. Instead, could you return the unwrapped error here and wrap where this function is called in loadSinglePluginFromURL and loadSinglePluginFromFile? That way both of those functions could include the location information of the plugin in the error message.
There was a problem hiding this comment.
Instead of just returning the value of loadSinglePlugin I wrapped that value with the context necessary to describe the URL or file. 👍
zubron
approved these changes
Nov 11, 2019
We currently allow loading plugins from the local file system but for sharing of plugins it makes sense to allow users to specify a URL. Fixes #986 Signed-off-by: John Schnake <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We currently allow loading plugins from the local file system
but for sharing of plugins it makes sense to allow users to
specify a URL.
Which issue(s) this PR fixes
Fixes #986
Special notes for your reviewer:
Release note: