Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to go modules #935

Merged
merged 1 commit into from
Oct 7, 2019
Merged

Move to go modules #935

merged 1 commit into from
Oct 7, 2019

Conversation

johnSchnake
Copy link
Contributor

What this PR does / why we need it:

  • removes vendor
  • removes dep from download/test steps
  • adds go.mod and go.sum

Which issue(s) this PR fixes
Fixes #933

Special notes for your reviewer:

Release note:

NONE

@johnSchnake johnSchnake requested a review from zubron October 2, 2019 17:58
Copy link
Contributor

@zubron zubron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😄

 - removes vendor
 - removes dep from download/test steps
 - adds go.mod and go.sum

Fixes #933

Signed-off-by: John Schnake <[email protected]>
@codecov-io
Copy link

Codecov Report

Merging #935 into master will decrease coverage by 0.21%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #935      +/-   ##
==========================================
- Coverage   47.78%   47.56%   -0.22%     
==========================================
  Files          76       76              
  Lines        5226     5178      -48     
==========================================
- Hits         2497     2463      -34     
+ Misses       2573     2565       -8     
+ Partials      156      150       -6
Impacted Files Coverage Δ
pkg/discovery/discovery.go 7.61% <0%> (-0.04%) ⬇️
pkg/client/results/reader.go 55.9% <0%> (ø) ⬆️
pkg/client/results/processing.go 82.92% <0%> (+5.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2686723...7dbc45d. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move to modules
3 participants