Get dockerhub image pushing to work on Travis #932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #932 +/- ##
=======================================
Coverage 47.56% 47.56%
=======================================
Files 76 76
Lines 5178 5178
=======================================
Hits 2463 2463
Misses 2565 2565
Partials 150 150Continue to review full report at Codecov.
|
I know we're moving away from Travis but I'm working out the details of getting our scripts to push appropriately. Moving this to CircleCI probably wont add much overhead. Related to #914 Signed-off-by: John Schnake <[email protected]>
|
Going to merge and just see how it goes; may need to follow up but to get the pushing logic to run we need to get the change onto master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know we're moving away from Travis but I'm working out the
details of getting our scripts to push appropriately. Moving
this to CircleCI probably wont add much overhead.
Related to #914