Add a disruptive taint to list of default tolerations #878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zubron
approved these changes
Sep 13, 2019
|
CI is failing due to a unit test which is checking the tolerations: https://github.com/heptio/sonobuoy/blob/master/pkg/plugin/driver/job/job_test.go#L209-L214 I added that check, and it's not very good :( sorry |
|
Thanks @zubron Fixed that test, I hadn't noticed it. Will wait until ci goes green and merge. |
A new conformance test in v1.16 will add a taint to a node which can impact the sonobuoy aggregator pod as well as the e2e pod. This change adds the toleration to both the default job podspec and the aggregator. The default daemonset podspec already tolerates all taints. Fixes #876 Signed-off-by: John Schnake <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #878 +/- ##
==========================================
- Coverage 46.96% 46.93% -0.03%
==========================================
Files 75 75
Lines 4904 4907 +3
==========================================
Hits 2303 2303
- Misses 2469 2472 +3
Partials 132 132
Continue to review full report at Codecov.
|
bradbeam
approved these changes
Sep 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
A new conformance test in v1.16 will add a taint to a node which
can impact the sonobuoy aggregator pod as well as the e2e pod.
This change adds the toleration to both the default job podspec
and the aggregator. The default daemonset podspec already tolerates
all taints.
Which issue(s) this PR fixes
Fixes #876
Special notes for your reviewer:
I created a v1.16 cluster which may not be strictly necessary. You may just need to target the newer tests:
Release note: