Remove hidden plugin command
#833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change removes the hidden `plugin` command. This command was intended for debugging the generation of plugin Job and DaemonSet manifests and is not in active use. There is currently other work in progress to remove the use of templates when creating plugin resources which means that a command to render the template is not required. If we decided to have a debug command there would be further work required to ensure that the same flow is used as is used in the plugin aggreator. Signed-off-by: Bridget McErlean <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #833 +/- ##
==========================================
+ Coverage 44.55% 44.73% +0.18%
==========================================
Files 76 75 -1
Lines 4624 4565 -59
==========================================
- Hits 2060 2042 -18
+ Misses 2431 2390 -41
Partials 133 133
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This change removes the hidden
plugincommand. This command wasintended for debugging the generation of plugin Job and DaemonSet
manifests and is not in active use. There is currently other work in
progress to remove the use of templates when creating plugin resources
which means that a command to render the template is not required. If we
decided to have a debug command there would be further work required to
ensure that the same flow is used as is used in the plugin aggreator.
Signed-off-by: Bridget McErlean [email protected]
Release note: