Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation for airgapped environments #1023

Merged
merged 1 commit into from
Dec 2, 2019

Conversation

zubron
Copy link
Contributor

@zubron zubron commented Nov 29, 2019

What this PR does / why we need it:
This change adds more instructions on how to run Sonobuoy in airgapped
environments. The documentation was previously missing details such as
how to use the images command, the fact that different versions of
Kubernetes use different image repositories, and used outdated
instructions for running custom Sonobuoy manifests.

This page now breaks down what is required for each plugin and includes
more explicit step by step details.

Signed-off-by: Bridget McErlean [email protected]

Which issue(s) this PR fixes

Special notes for your reviewer:
This PR references the new command gen default-image-config which is proposed in #1022.

@codecov-io
Copy link

Codecov Report

Merging #1023 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1023   +/-   ##
=======================================
  Coverage   48.33%   48.33%           
=======================================
  Files          76       76           
  Lines        5437     5437           
=======================================
  Hits         2628     2628           
  Misses       2651     2651           
  Partials      158      158

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44be251...4ff2a6d. Read the comment docs.

This change adds more instructions on how to run Sonobuoy in airgapped
environments. The documentation was previously missing details such as
how to use the `images` command, the fact that different versions of
Kubernetes use different image repositories, and used outdated
instructions for running custom Sonobuoy manifests.

This page now breaks down what is required for each plugin and includes
more explicit step by step instructions.

Signed-off-by: Bridget McErlean <[email protected]>
@zubron zubron force-pushed the improve-airgapped-cluster-docs branch from 4ff2a6d to 0cbdc71 Compare December 2, 2019 15:22
@zubron zubron merged commit 05dc053 into vmware-tanzu:master Dec 2, 2019
@zubron zubron deleted the improve-airgapped-cluster-docs branch December 2, 2019 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update airgap docs to use sonobuoy run -f instead of kubectl
3 participants