-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve site accessibility score #1017
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one change I can see; otherwise seems fine to me as long as @jonasrosland is on board.
Codecov Report
@@ Coverage Diff @@
## master #1017 +/- ##
==========================================
- Coverage 48.54% 48.41% -0.13%
==========================================
Files 77 77
Lines 5498 5498
==========================================
- Hits 2669 2662 -7
- Misses 2670 2675 +5
- Partials 159 161 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you for helping us update the Sonobuoy site @SDBrett!
Fixes: vmware-tanzu#1016 Updates to site colours to align with VMware branding and improve contrast rations for site accessibility. Update to youtube plugin for that it can will insert an iframes title as well. New usage of liquid template `{% youtube "<title>" %} Updates to links to provide link text Updates to images to add alt text. Accessibility changes assist people visiting the site with visual impairments and improve the function of text to speech tools such as Jaws. Change includes moving custom-site/css/sonobouy.css to /site/_scss/settings/ for configuration consistency. Signed-off-by: Brett Johnson <[email protected]>
Made a minor change to improve link colour in text based on feedback that they did not stand out enough and where easy to miss. Added link colour for section.grey as lighter links do not have enough contrast ratio with the grey background. This is used on the home page. Rebased |
Thanks a ton for the help with this submission. |
Fixes: #1016
Updates to site colours to align with VMware branding and improve contrast rations for site accessibility.
Update to youtube plugin for that it can will insert an iframes title as well. New usage of liquid template `{% youtube "<title>" %}
Updates to links to provide link text
Updates to images to add alt text.
Accessibility changes assist people visiting the site with visual impairments and improve the function of text to speech tools such as Jaws.
Change includes moving custom-site/css/sonobouy.css to /site/_scss/settings/ for configuration consistency.
Signed-off-by: Brett Johnson [email protected]
What this PR does / why we need it:
Which issue(s) this PR fixes
Special notes for your reviewer:
Release note: