Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve site accessibility score #1017

Merged
merged 1 commit into from
Dec 5, 2019

Conversation

SDBrett
Copy link
Contributor

@SDBrett SDBrett commented Nov 27, 2019

Fixes: #1016

Updates to site colours to align with VMware branding and improve contrast rations for site accessibility.

Update to youtube plugin for that it can will insert an iframes title as well. New usage of liquid template `{% youtube "<title>" %}

Updates to links to provide link text

Updates to images to add alt text.

Accessibility changes assist people visiting the site with visual impairments and improve the function of text to speech tools such as Jaws.

Change includes moving custom-site/css/sonobouy.css to /site/_scss/settings/ for configuration consistency.

Signed-off-by: Brett Johnson [email protected]

What this PR does / why we need it:

Which issue(s) this PR fixes

  • Fixes #

Special notes for your reviewer:

Release note:

release-note

Copy link
Contributor

@johnSchnake johnSchnake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one change I can see; otherwise seems fine to me as long as @jonasrosland is on board.

site/docs/master/README.md Outdated Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Dec 2, 2019

Codecov Report

Merging #1017 into master will decrease coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1017      +/-   ##
==========================================
- Coverage   48.54%   48.41%   -0.13%     
==========================================
  Files          77       77              
  Lines        5498     5498              
==========================================
- Hits         2669     2662       -7     
- Misses       2670     2675       +5     
- Partials      159      161       +2
Impacted Files Coverage Δ
pkg/plugin/aggregation/aggregator.go 72.67% <0%> (-3.11%) ⬇️
cmd/sonobuoy/app/status.go 57.54% <0%> (-1.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a768c66...1429ac2. Read the comment docs.

Copy link
Contributor

@jonasrosland jonasrosland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for helping us update the Sonobuoy site @SDBrett!

Fixes: vmware-tanzu#1016

Updates to site colours to align with VMware branding and improve contrast rations for site accessibility.

Update to youtube plugin for that it can will insert an iframes title as well. New usage of liquid template `{% youtube "<title>" %}

Updates to links to provide link text

Updates to images to add alt text.

Accessibility changes assist people visiting the site with visual impairments and improve the function of text to speech tools such as Jaws.

Change includes moving custom-site/css/sonobouy.css to /site/_scss/settings/ for configuration consistency.

Signed-off-by: Brett Johnson <[email protected]>
@SDBrett
Copy link
Contributor Author

SDBrett commented Dec 5, 2019

Made a minor change to improve link colour in text based on feedback that they did not stand out enough and where easy to miss.

Added link colour for section.grey as lighter links do not have enough contrast ratio with the grey background. This is used on the home page.

Rebased

@johnSchnake
Copy link
Contributor

Thanks a ton for the help with this submission.

@johnSchnake johnSchnake self-requested a review December 5, 2019 03:33
@johnSchnake johnSchnake merged commit 8a0c2ac into vmware-tanzu:master Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Site has poor accessibility score
4 participants