Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No-results error mode has lack of logging #915

Closed
johnSchnake opened this issue Sep 28, 2019 · 1 comment
Closed

No-results error mode has lack of logging #915

johnSchnake opened this issue Sep 28, 2019 · 1 comment
Assignees
Milestone

Comments

@johnSchnake
Copy link
Contributor

See comment below; requesting more logging and a timestamp on the error result objects. Should ensure that all the code paths are covered to make debugging more clear.

The fact that the error isn't reported in sonobuoy results is already being addressed in another issue.


From pod info, the container exited 1 at

"finishedAt": "2019-09-28T08:19:20Z"

And in the Sonobuoy logs, it stopped waiting for results at:

time="2019-09-28T08:24:20Z" level=info msg="Last update to annotations on exit"

So it did wait 5 more miniutes after the container terminated to see results.

  1. I think more logging was needed here to make this clear. There are logs in place
    for when we get results, but apparently the logs are not sufficiently clear when
    this error mode occurs.
  2. The error reported mentioned the termination, it would have also been helpful to list the
    time that the error message was generated (so I didn't have to cross-reference the other set of logs)
  3. It does seem to be an issue with the upstream issue. Going to take a look there and try
    to repro. This sort of thing has happened before unfortunately and caused us to push our own
    conformance image to patch the issue.

Originally posted by @johnSchnake in #910 (comment)

@johnSchnake johnSchnake added this to the v0.16.2 milestone Sep 30, 2019
@johnSchnake
Copy link
Contributor Author

This is also addressed by #938 since multiple timeout messages were added. That PR also changes a bit of the other timeout logic which I think makes it even more clear. Closing as duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants