Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sonobuoy must handle conformance+live cluster differently than full conformance #877

Closed
johnSchnake opened this issue Sep 12, 2019 · 1 comment · Fixed by #885
Closed
Assignees
Labels

Comments

@johnSchnake
Copy link
Contributor

The CNCF conformance instructions do tell people to run sonobuoy run to get results for certification.

Historically sonobuoy ran the conformance tag but skipped alpha, disruptive, flakey, etc. That was all fine since they should have been exclusive. Now that those overlap some (if kubernetes/kubernetes#82664 is updated based on the peer feedback), we'll have to accommodate both flows:

  • if a user wants results for certification, do they run sonobuoy run and get potentially destructive tests? These wouldn't be completely safe to run in a prod cluster.
  • if a user wants to test their running cluster, what do they run?

Sonobuoy will make this pretty simple since we have "modes" for the e2e plugin. Currently, we have the Conformance and Quick modes.

The new mode naming will need some thought:

  • LiteConformance vs Conformance
  • NonDestructive vs Conformance

And we'll need to decide which is the default

@johnSchnake
Copy link
Contributor Author

cc @timothysc FYI

johnSchnake added a commit that referenced this issue Sep 17, 2019
)

With K8s v1.16, disruptive tests may not be part of the conformance
suite. As a result we need to ensure that user workloads are
protected by default while still allowing for CNCF certification
test runs.

In this PR we:
 - rename the default `conformance` mode to be `non-disruptive-conformance`
and modified the skip list appropriately.
 - added a `certified-conformance` mode which does not provide a skip list
and will run even the disruptive tests
 - tweaked the naming to use lower case values by default to be more
consistent with our other flags/naming

Fixes #877
Fixes #875

Signed-off-by: John Schnake <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant