Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sonobuoy must tolerate certain test taints #876

Closed
johnSchnake opened this issue Sep 12, 2019 · 0 comments · Fixed by #878
Closed

Sonobuoy must tolerate certain test taints #876

johnSchnake opened this issue Sep 12, 2019 · 0 comments · Fixed by #878
Milestone

Comments

@johnSchnake
Copy link
Contributor

What steps did you take and what happened:
See kubernetes/kubernetes#82664 for some context; lots of conversations in slack.

TL;DR; we may allow some conformance tests to be also disruptive; specifically there are some w.r.t. taints that were causing evictions on a node and impacting sonobuoy. We need to tolerate these taints (or all taints?) in order to be sure that we do not get evicted during a test run.

What did you expect to happen:
Sonobuoy MUST be able to run all conformance tests (and, ideally, all of the e2e suite); not get evicted due to a taint added during a test.

Environment:

  • Sonobuoy version: v.1.15.3
  • Kubernetes version: (use kubectl version): v1.16.0.beta.3
@johnSchnake johnSchnake added this to the v0.15.4 milestone Sep 12, 2019
johnSchnake added a commit that referenced this issue Sep 14, 2019
A new conformance test in v1.16 will add a taint to a node which
can impact the sonobuoy aggregator pod as well as the e2e pod.

This change adds the toleration to both the default job podspec
and the aggregator. The default daemonset podspec already tolerates
all taints.

Fixes #876

Signed-off-by: John Schnake <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant