Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Namespaced queries getting items from other namespaces #839

Closed
johnSchnake opened this issue Aug 15, 2019 · 0 comments · Fixed by #842
Closed

Namespaced queries getting items from other namespaces #839

johnSchnake opened this issue Aug 15, 2019 · 0 comments · Fixed by #842
Assignees
@johnSchnake
Labels
kind/bug Behavior isn't as expected or intended p1-important
Milestone
v0.15.2

Comments

@johnSchnake
Copy link
Contributor

What steps did you take and what happened:

  • Ran a simple plugin like systemd-logs
  • checked the query results for pods in heptio-sonobuoy
  • found things like api server and other pods from other namespaces

What did you expect to happen:
Each namespace query should only result in items from its namespace

Anything else you would like to add:
This was repeated for other types/namespaces, not just pods/heptio-sonobuoy

Environment:

  • Sonobuoy version: v0.15.1
@johnSchnake johnSchnake added kind/bug Behavior isn't as expected or intended p1-important labels Aug 15, 2019
@johnSchnake johnSchnake added this to the v0.15.2 milestone Aug 15, 2019
@johnSchnake johnSchnake self-assigned this Aug 15, 2019
@johnSchnake johnSchnake mentioned this issue Aug 15, 2019
Merged
johnSchnake added a commit that referenced this issue Aug 15, 2019
@johnSchnake
Ensure we filter resources by namespace (#842)
2fb844c 
This got removed in a recent PR but should not have.

When querying namespaced resources you need the field selector
set. This is not something that can easily be tested in unit tests
since that logic happens on the server side and mocks would not
hit that code.

Fixes #839

Signed-off-by: John Schnake <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnSchnake johnSchnake

Labels
kind/bug Behavior isn't as expected or intended p1-important
Projects
None yet
Milestone
v0.15.2
Development

Successfully merging a pull request may close this issue.

Ensure we filter resources by namespace
1 participant
@johnSchnake