Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename master to aggregator #238

Closed
chuckha opened this issue Feb 12, 2018 · 7 comments · Fixed by #847
Closed

rename master to aggregator #238

chuckha opened this issue Feb 12, 2018 · 7 comments · Fixed by #847
Assignees
@johnSchnake
Labels
p2-moderate
Milestone
v0.15.3

Comments

@chuckha
Copy link
Contributor

chuckha commented Feb 12, 2018 •
edited
Loading

In the spirit of kubernetes/website#6525 I'd like to rename master to something else.

This will take a bit of time, continue using master until we agree on a new noun.

We discussed and decided aggregator is the thing to use
@chuckha chuckha self-assigned this Feb 12, 2018
@timothysc
Copy link
Contributor

@chuckha - How does collector sound? It's not really a controller in the k8s sense.

@chuckha
Copy link
Contributor Author

chuckha commented Feb 12, 2018

@timothysc we had agreed on controller offline last week, but for now I will continue to use master until we can agree on a different noun.

@chuckha chuckha changed the title rename master to controller rename master to something else Feb 12, 2018
@chuckha
Copy link
Contributor Author

chuckha commented Feb 12, 2018

I'm not super happy with collector because it feels overly specific as collecting results is only one of the responsibilities.

we could go with something like control-plane, ControlPlane, controlplane?

@chuckha chuckha changed the title rename master to something else rename master to aggregator Feb 13, 2018
@timothysc timothysc added this to the v0.11.0 milestone Feb 21, 2018
@timothysc
Copy link
Contributor

stretch goal for 0.11.0

@timothysc
Copy link
Contributor

the subcommand is now hidden, but we should still make the change, but not a blocker for this cycle.

@timothysc timothysc modified the milestones: v0.11.0, v0.12.0 Mar 1, 2018
@johnSchnake johnSchnake assigned johnSchnake and unassigned chuckha Jun 17, 2019
@johnSchnake johnSchnake modified the milestones: v1.0.0, v0.15.1 Jun 17, 2019
@johnSchnake johnSchnake mentioned this issue Jun 17, 2019
Closed
@johnSchnake johnSchnake modified the milestones: v0.15.1, v0.15.2 Aug 5, 2019
@johnSchnake
Copy link
Contributor

I had a draft PR that tried to make this change and I think it was working but I'm honestly pretty concerned about some edge cases and backward/forward compatibility.

I think that if we just update all of our docs/comments going forward and accept the name as just a historical hold over we can close this ticket. Feel free to disagree.

@johnSchnake johnSchnake added this to the v0.15.3 milestone Aug 16, 2019
@chuckha
Copy link
Contributor Author

chuckha commented Aug 19, 2019

seems good to me if backwards compatibility is going to be an issue.

@johnSchnake johnSchnake mentioned this issue Aug 19, 2019
Merged
johnSchnake added a commit that referenced this issue Aug 23, 2019
@johnSchnake
Rename master to aggregator (#847)
973e782 
Slightly more intuitive and useful name. Kept the old name
as an alias which we can decide to remove later if we want.

Did not update a few of the config values or script names
that are named with 'master' in order to avoid potentially
breaking changes.

Fixes #238

Signed-off-by: John Schnake <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnSchnake johnSchnake

Labels
p2-moderate
Projects
None yet
Milestone
v0.15.3
Development

Successfully merging a pull request may close this issue.

Rename master to aggregator
Rename master to aggregator
4 participants
@chuckha @timothysc @johnSchnake @liztio