Workaround for non-existent GH repo tags. #6221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Nelson <[email protected]>
✅ Deploy Preview for kubeapps-dev canceled.
|
absoludity
added a commit
that referenced
this pull request
May 1, 2023
<!-- Before you open the request please review the following guidelines and tips to help it be more easily integrated: - Describe the scope of your change - i.e. what the change does. - Describe any known limitations with your change. - Please run any tests or examples that can exercise your modified code. Thank you for contributing! --> ### Description of the change After getting a couple of dev chart auto-created PRs like #6236, which are doing nothing except setting our development images from `latest` (which they should be in the dev chart) to a fixed version, I realised that in #6221 I'd actually updated the incorrect part of the script. This PR fixes that, by ensuring that we don't refer to `tag` in `replaceImage_latestToProduction` since we don't have the production values of the tag currently (until we update to use the dockerhub API as per #6220) - this was the intended change of the previous PR - and reverts the unintended change that updated `replaceImage_productionToLatest` so that we again expect `latest` for our own images in the dev chart. ### Benefits <!-- What benefits will be realized by the code change? --> We're no longer bothered by noop PRs such as #6236 . ### Possible drawbacks <!-- Describe any known limitations with your change --> ### Applicable issues <!-- Enter any applicable Issues here (You can reference an issue using #) --> - fixes # ### Additional information <!-- If there's anything else that's important and relevant to your pull request, mention that information here.--> Signed-off-by: Michael Nelson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
See #6220 for a description.
Benefits
We can release.
Possible drawbacks
We'll need to manually update the auto-generated PR for the upstream change with the correct images.
Applicable issues
Additional information