Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch resources plugin to use connect core packages client and other clean-ups. #6204

Merged
merged 9 commits into from
Apr 18, 2023
Merged

Switch resources plugin to use connect core packages client and other clean-ups. #6204

merged 9 commits into from
Apr 18, 2023

Conversation

absoludity
Copy link
Contributor

@absoludity absoludity commented Apr 18, 2023 •
edited
Loading

Description of the change

Removes the last redundant pieces of functionality after the switch to connect gRPC-Web. In particular:

  • Switches the resources plugin to use the connect gRPC client rather than the non-connect one, so that the header auth can be used, which meant
  • Remove the last use of auth in the go context and supporting function
  • Remove the subscriptions state in the dashboard, which was related to the non-connect gRPC-Web implementation that subscribed to events rather than using async/await.
  • Remove redundant closeRequestResources action.

Benefits

Completes the work for 6013

Possible drawbacks

Applicable issues

Additional information

@netlify
Copy link

netlify bot commented Apr 18, 2023 •
edited
Loading

✅ Deploy Preview for kubeapps-dev canceled.

Name Link
🔨 Latest commit e41c5a7
🔍 Latest deploy log https://app.netlify.com/sites/kubeapps-dev/deploys/643e2f5aa2ed720008415fb7

@absoludity
Remove unused fn
e6b8955 
Signed-off-by: Michael Nelson <[email protected]>
@absoludity
Use port for client.
5575407 
Signed-off-by: Michael Nelson <[email protected]>
@absoludity
Remove subscription state from async resource collection.
8a1406b 
Signed-off-by: Michael Nelson <[email protected]>
@absoludity
Remove unused import.
677bb74 
Signed-off-by: Michael Nelson <[email protected]>
@absoludity
Remove dashboard onComplete as now unnecessary.
81e3d39 
Signed-off-by: Michael Nelson <[email protected]>
@absoludity
Lint.
71a7f2f 
Signed-off-by: Michael Nelson <[email protected]>
@absoludity
Prettier
6618051 
Signed-off-by: Michael Nelson <[email protected]>
@absoludity
Re-instate remove getInstalledPkgStatus, just without subscriptions.
e41c5a7 
Signed-off-by: Michael Nelson <[email protected]>
@absoludity absoludity marked this pull request as ready for review April 18, 2023 06:02
@absoludity absoludity changed the title Switch resources to use connect core packages client. Switch resources plugin to use connect core packages client and other clean-ups. Apr 18, 2023
@absoludity absoludity merged commit 0a13517 into main Apr 18, 2023
@absoludity absoludity deleted the 6013-removal-3 branch April 18, 2023 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace improbable-eng/grpc-web with grpc/web
2 participants
@absoludity @vmwclabot