Ensure loaded plugin config is saved to helm server.

[absoludity]

Description of the change

In #5339 we inadvertently switched from an assignment to a short variable declaration:

-		pluginConfig, err = common.ParsePluginConfig(pluginConfigPath)
+		pluginConfig, err := common.ParsePluginConfig(pluginConfigPath)

which meant that, in context, a new pluginConfig var was created in that scope, so that the actual pluginConfig var from the outside scope remained empty.

Benefits

Plugin config works again for the Helm plugin.

Possible drawbacks

Applicable issues

• fixes [regression] Cannot control which chart versions are displayed #6020

Additional information

I spent some time trying to write a test for this, but I could either extract the 5 lines to a separate function and test that or test the NewServer function itself. The latter is very difficult because it instantiates a bunch of network requests, and the former seems redundant since we already extract the functionality to the common.ParsePluginConfig() function... it's really just a golang gotcha that is important to be aware of: a := foo is equivalent to var a atype \n a = foo and so is always creating a new variable in that scope.

[netlify]

✅ Deploy Preview for kubeapps-dev canceled.

Name	Link
🔨 Latest commit	03dd109
🔍 Latest deploy log	https://app.netlify.com/sites/kubeapps-dev/deploys/63f7ffc4524199000856ba59