Add default value selector #5885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixes issue to enable hyphens in custom values files. Signed-off-by: Michael Nelson <[email protected]>
✅ Deploy Preview for kubeapps-dev canceled.
|
Signed-off-by: Michael Nelson <[email protected]>
absoludity
changed the title
Signed-off-by: Michael Nelson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michael Nelson [email protected]
Description of the change
This PR adds a default values selector to the DeploymentForm which is only displayed if a package has multiple additional values file in the package. For packages with multiple additional values files, the deploy initially uses the package values.yaml, but the form explains why the selector is available:
If the user selects a different default values file, the form is updated with that files content, ready for editing:
And finally, if the user edits the fields, the diff is against the selected default, as expected:
Also fixes issue to enable hyphens in custom values files (hard to find bug found while testing this PR).
Benefits
Possible drawbacks
Applicable issues
Additional information
Tomorrow (actually, Friday), I will verify the behaviour for installed packages being upgraded.