Improve wording to avoid implying pinniped is used either way. #5695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kubeapps-dev canceled.Built without sensitive environment variables
|
ppbaena
approved these changes
Nov 23, 2022
absoludity
force-pushed
the
improve-oidc-docs
branch
from
82ef38e
to
569d910
Compare
Signed-off-by: Michael Nelson <[email protected]>
absoludity
force-pushed
the
improve-oidc-docs
branch
from
569d910
to
c17552b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michael Nelson [email protected]
Description of the change
While chatting about OIDC configuration with @RGPosadas I was looking through the docs and found that it reads currently as if you should use Pinniped either way.
This change just clears that up a bit, I hope, so that people use the cluster's own OIDC support when they can, and pinniped when they can't.
Benefits
Possible drawbacks
Applicable issues
Additional information