issue4870 - refactor helm to use managed-by annotation #5673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kubeapps-dev canceled.Built without sensitive environment variables
|
| @@ -31,12 +31,16 @@ const ( | |||
| SecretCaKey = "ca.crt" | |||
| SecretAuthHeaderKey = "authorizationHeader" | |||
| DockerConfigJsonKey = ".dockerconfigjson" | |||
|
|
|||
There was a problem hiding this comment.
may I suggest "app.kubernetes.io/managed-by" for the key (ref https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/#labels). Seemed fitting to me so I was planning to use that in flux plugin
There was a problem hiding this comment.
i do not remember what we discussion we previously had, but this is following what is in the carvel plugin.
if we decide to change, we would either have different implementations, or need to change what we have in carvel.
gfichtenholt
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
The previous fix for issue 4870 did not introduce the managed-by annotation as per the spec, but relied on naming pattern for backward compatibility.
This presents the issue that new secrets will still depend on the old naming pattern.
This change ensures that new or updated secrets have the managed-by annotation, and that the code looks for this annotation.
The code stills falls back to the naming pattern for backward compatibility, but now with a deprecation path. We can remove the naming pattern support in a future version.
Applicable issues