Issue5542 - Unable to edit or delete newly created flux package repository

[dlaloue-vmware]

Description of the change

This change completes the changes previously made in an earlier change regarding flux repository edit/delete buttons enablement issues.
The main switch is to change the scope of a flux repository from global to namespaced. A flux repository behaves more similar to a namespaced repository than a global repository, making its handling easier in the UI.

The change also includes a fix where carvel global repositories were not included, even if the user has list/view access to them.

Finally, the create/update repository dialog in the UI has been updated to reflect that the default scope of a flux repository is namespaced, and not global, and that it cannot be changed.

Benefits

Users that have namespace-only access can now properly manage the flux repositories they created.

Applicable issues

• fixes Unable to edit or delete newly created flux package repository  #5542

Additional information

This change does not include a fix for the page and table buttons when the "show in all namespaces" toggle is on.
Users can use the workaround to toggle off the switch. For this reason, a proper fix is best delayed to when the repository page is revamped.

[netlify]

✅ Deploy Preview for kubeapps-dev canceled.

Built without sensitive environment variables

Name	Link
🔨 Latest commit	38f2f44
🔍 Latest deploy log	https://app.netlify.com/sites/kubeapps-dev/deploys/6377b78e7061a9000ae8bcd4

[gfichtenholt]

just adding an explicit note here so we can link to it in the future: this change will make all repositories in flux plugin "namespaced". Previously they were NOT namespaced.
per slack: ...change is to expand the definition of namespaced a bit 🙂
“if you create a repo in one namespace, it is available to be used in that namespace, and may be available to be used in other namespaces you have access to, if supported by the plugin”.
and only flux (without no-cross enabled) supports such extended capability

[gfichtenholt]

My only ask is in flux repo.go, put an explicit comment mentioning that we chose to change the way flux repos are returning the namespacedScoped flag on purpose with maybe a link ref to the discussion. This kind of thing tends to be forgotten quickly. Thanks

[dlaloue-vmware]

yes, will do.