Move gke_e2e_tests from reusable workflow to custom action #5660
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jesús Benito Calzada [email protected]
Description of the change
Currently, we have a reusable workflow for running the e2e tests in a GKE cluster. This approach, although valid is probably not the best one for this problem as we have to explicitly declare every single env var the workflow use as an input, pass those env vars in every call to the workflow, and finally, inside the reusable workflow turn the inputs into the env vars the scripts are relying on. A better approach for this is to define a custom action using the
composite
approach, that will automatically inherit all the env vars available in the calling workflow.Benefits
Make our GHA setup simpler a more easily maintainable.
Possible drawbacks
None
Applicable issues