Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move gke_e2e_tests from reusable workflow to custom action #5660

Conversation

beni0888
Copy link
Collaborator

Signed-off-by: Jesús Benito Calzada [email protected]

Description of the change

Currently, we have a reusable workflow for running the e2e tests in a GKE cluster. This approach, although valid is probably not the best one for this problem as we have to explicitly declare every single env var the workflow use as an input, pass those env vars in every call to the workflow, and finally, inside the reusable workflow turn the inputs into the env vars the scripts are relying on. A better approach for this is to define a custom action using the composite approach, that will automatically inherit all the env vars available in the calling workflow.

Benefits

Make our GHA setup simpler a more easily maintainable.

Possible drawbacks

None

Applicable issues

@netlify
Copy link

netlify bot commented Nov 17, 2022

Deploy Preview for kubeapps-dev canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 6b314ef
🔍 Latest deploy log https://app.netlify.com/sites/kubeapps-dev/deploys/63762bac9a7bfd0009fce9ff

@beni0888 beni0888 self-assigned this Nov 17, 2022
@beni0888 beni0888 added component/ci Issue related to kubeapps ci system github_actions Pull requests that update GitHub Actions code labels Nov 17, 2022
@beni0888 beni0888 added this to the Migrate CI to GitHub Actions milestone Nov 17, 2022
@beni0888
Copy link
Collaborator Author

Closing this PR as it is not feasible to continue with it due to a bug in GHA actions by which secrets containing JSON docs as values don't get masked when shown in the build logs. That added to the fact that custom actions don't inherit the secrets from the caller workflow and they have to be passed as inputs, makes it impossible to continue with this task. We'll have to stick to a reusable workflow, at least until the GitHub Actions guys fix the bug.

@beni0888 beni0888 closed this Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-not-required component/ci Issue related to kubeapps ci system github_actions Pull requests that update GitHub Actions code
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants