Consistent json schema validation of SliderParams #5533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antonio Gamez Diaz <[email protected]>
Signed-off-by: Antonio Gamez Diaz <[email protected]>
Signed-off-by: Antonio Gamez Diaz <[email protected]>
Signed-off-by: Antonio Gamez Diaz <[email protected]> Conflicts: dashboard/src/shared/schema.ts
Base automatically changed from
3-5525-schemaAnnotations
to
1-3535-customSchema
October 21, 2022 16:42
### Description of the change In #5436 we mentioned that several fields were still pending, namely - 1st level: object (at least, as array of tuples <string, any> for defining each property. - Array level: enum, arrays, objects WRT the top-level objects, it is not an actual problem: if they have `properties`, they will get rendered as any other nested param more. It is only the case when it lacks the `properties` fields that we need to handle. - Solution: allow any serialized object like `{"foo": 1234}` and add more validation messages. WRT the array-level properties: - Solution for enum: use the same approach as in the top-level enum. - Solution for arrays and objects: use the same approach as in the top-level objects: render a text field but enforce validation. Additionally, the array now enforces `maxItems` and `minItems` ### Benefits Every json schema datatype is now supported. ### Possible drawbacks N/A ### Applicable issues - fixes #5436 ### Additional information > **Note** > This PR is part of a series of PRs aimed at closing [this milestone](https://github.com/vmware-tanzu/kubeapps/milestone/27). I have split the changes to ease the review process, but as there are many interrelated changes, the tests will be performed in a separate PR (on top of the branch containing all the changes). > PR 5 out of 6 #### `Top-level objects`:  #### `Array<enum>`:  #### `Array<array>`:  #### `Array<object>`:  #### `YAML output`  #### `Array max/min items` Min items:  Max items:  Signed-off-by: Antonio Gamez Diaz <[email protected]>
Signed-off-by: Antonio Gamez Diaz <[email protected]> Conflicts: dashboard/src/components/DeploymentForm/DeploymentFormBody/BasicDeploymentForm/TabularSchemaEditorTable/Params/ArrayParam.tsx dashboard/src/components/DeploymentForm/DeploymentFormBody/BasicDeploymentForm/TabularSchemaEditorTable/Params/SliderParam.tsx
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
As pointed out by @dud225, we weren't enforcing the numeric validation consistently in both the slider and the text input. Besides, we were missing some json schema fields like
exclusiveMinimumandexclusiveMaximum.This PR is to fix that.
Benefits
Consistent param validation
Possible drawbacks
N/A
Applicable issues
Additional information
Also, note the HTML5 additional validation (user's browser locale msgs):