Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix push_images job from GH Actions workflow #5441

Merged
merged 1 commit into from
Oct 7, 2022

Conversation

beni0888
Copy link
Collaborator

@beni0888 beni0888 commented Oct 7, 2022

Signed-off-by: Jesús Benito Calzada [email protected]

Description of the change

This PR fixes some errors in the push_images job from the Kubeapps general workflow in GH Actions.

Benefits

The push_images job works as expected and images are uploaded to Docker Hub upon commits to the main branch.

Possible drawbacks

None.

Applicable issues

Additional information

Signed-off-by: Jesús Benito Calzada <[email protected]>
@netlify
Copy link

netlify bot commented Oct 7, 2022

Deploy Preview for kubeapps-dev canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 94ba3eb
🔍 Latest deploy log https://app.netlify.com/sites/kubeapps-dev/deploys/63404aa80f9c5500088abd8b

@beni0888 beni0888 self-assigned this Oct 7, 2022
@beni0888 beni0888 added kind/bug An issue that reports a defect in an existing feature component/ci Issue related to kubeapps ci system labels Oct 7, 2022
@beni0888 beni0888 added this to the CI & E2E test improvements milestone Oct 7, 2022
@beni0888 beni0888 marked this pull request as ready for review October 7, 2022 15:51
Copy link
Collaborator

@castelblanque castelblanque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@beni0888 beni0888 merged commit 16b67d3 into vmware-tanzu:main Oct 7, 2022
@beni0888 beni0888 deleted the fix-push-images-gha branch October 7, 2022 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-not-required component/ci Issue related to kubeapps ci system kind/bug An issue that reports a defect in an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants