Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[velero] customize client-qps and client-burst #222

Merged
merged 1 commit into from
Feb 24, 2021

Conversation

tareksha
Copy link
Contributor

Signed-off-by: Tareq Sharafy [email protected]

Special notes for your reviewer:

This change allows a users to customize client QPS and burst rate flexibly according to the load in their setups from the chart directly without applying ad-hoc modifications or relying on hard-coded defaults.

Avoid running into performances issues as described in vmware-tanzu/velero#3191

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the values.yaml or README.md
  • Title of the PR starts with chart name (e.g. [velero])

@jenting jenting changed the title customize client-qps and client-burst [velero] customize client-qps and client-burst Feb 24, 2021
jenting
jenting previously approved these changes Feb 24, 2021
Copy link
Collaborator

@jenting jenting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank u.

@tareksha
Copy link
Contributor Author

hi @jenting , bumped the version again after main was merged

Copy link
Collaborator

@jenting jenting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tareqhs Thanks again.

@jenting
Copy link
Collaborator

jenting commented Feb 24, 2021

@cpanato @carlisia PTAL 🙇‍♂️

Copy link
Contributor

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this PR
/lgtm

@jenting jenting merged commit 1fd6641 into vmware-tanzu:main Feb 24, 2021
@tareksha tareksha deleted the client_qps_burst branch February 24, 2021 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants