Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: vmware-tanzu/helm-charts
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: velero-4.3.0
Choose a base ref
...
head repository: vmware-tanzu/helm-charts
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: velero-4.4.0
Choose a head ref
  • 4 commits
  • 5 files changed
  • 3 contributors

Commits on Aug 6, 2023

  1. Add toggle to disable annotations

    Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
    jkroepke committed Aug 6, 2023

    Verified

    This commit was signed with the committer’s verified signature.
    jkroepke Jan-Otto Kröpke
    Copy the full SHA
    824f2a6 View commit details

Commits on Aug 7, 2023

  1. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    3c8cfb9 View commit details
  2. bump version

    Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
    jkroepke committed Aug 7, 2023

    Verified

    This commit was signed with the committer’s verified signature.
    jkroepke Jan-Otto Kröpke
    Copy the full SHA
    198b128 View commit details

Commits on Aug 8, 2023

  1. Merge pull request #487 from jkroepke/helmHookAnnotations

    [velero] Add toggle to disable annotations
    qiuming-best authored Aug 8, 2023

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    2892f89 View commit details
2 changes: 1 addition & 1 deletion charts/velero/Chart.yaml
Original file line number Diff line number Diff line change
@@ -3,7 +3,7 @@ appVersion: 1.11.1
kubeVersion: ">=1.16.0-0"
description: A Helm chart for velero
name: velero
version: 4.3.0
version: 4.4.0
home: https://github.com/vmware-tanzu/velero
icon: https://cdn-images-1.medium.com/max/1600/1*-9mb3AKnKdcL_QD3CMnthQ.png
sources:
2 changes: 2 additions & 0 deletions charts/velero/templates/backupstoragelocation.yaml
Original file line number Diff line number Diff line change
@@ -9,8 +9,10 @@ metadata:
name: {{ .name | default "default" }}
namespace: {{ $.Release.Namespace }}
annotations:
{{- if $.Values.helmHookAnnotations }}
"helm.sh/hook": post-install,post-upgrade,post-rollback
"helm.sh/hook-delete-policy": before-hook-creation
{{- end }}
labels:
app.kubernetes.io/name: {{ include "velero.name" $ }}
app.kubernetes.io/instance: {{ $.Release.Name }}
2 changes: 2 additions & 0 deletions charts/velero/templates/schedule.yaml
Original file line number Diff line number Diff line change
@@ -9,8 +9,10 @@ metadata:
{{- if $schedule.annotations }}
{{- toYaml $schedule.annotations | nindent 4 }}
{{- end }}
{{- if $.Values.helmHookAnnotations }}
"helm.sh/hook": post-install,post-upgrade,post-rollback
"helm.sh/hook-delete-policy": before-hook-creation
{{- end }}
labels:
app.kubernetes.io/name: {{ include "velero.name" $ }}
app.kubernetes.io/instance: {{ $.Release.Name }}
2 changes: 2 additions & 0 deletions charts/velero/templates/volumesnapshotlocation.yaml
Original file line number Diff line number Diff line change
@@ -9,8 +9,10 @@ metadata:
name: {{ .name | default "default" }}
namespace: {{ $.Release.Namespace }}
annotations:
{{- if $.Values.helmHookAnnotations }}
"helm.sh/hook": post-install,post-upgrade,post-rollback
"helm.sh/hook-delete-policy": before-hook-creation
{{- end }}
labels:
app.kubernetes.io/name: {{ include "velero.name" $ }}
app.kubernetes.io/instance: {{ $.Release.Name }}
4 changes: 4 additions & 0 deletions charts/velero/values.yaml
Original file line number Diff line number Diff line change
@@ -24,6 +24,10 @@ annotations: {}
# Labels to add to the Velero deployment's. Optional.
labels: {}

# helmHookAnnotations is required to deploy CustomResources after deploying CRDs. If you manage your CRDs outside of this helm chart
# or using ArgoCD, you are able to disable the helm hooks annotations.
helmHookAnnotations: true

# Annotations to add to the Velero deployment's pod template. Optional.
#
# If using kube2iam or kiam, use the following annotation with your AWS_ACCOUNT_ID