Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cluster upgrade test #616

Merged
merged 1 commit into from
Jun 27, 2022
Merged

Conversation

Madhur97
Copy link
Contributor

@Madhur97 Madhur97 commented Jun 23, 2022

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #621

Additional information

Special notes for your reviewer

@Madhur97 Madhur97 force-pushed the cluster-upgrade-e2e branch 5 times, most recently from 0bfb965 to d8f7b26 Compare June 23, 2022 19:19
@Madhur97 Madhur97 changed the title [WIP] cluster upgrade test Cluster upgrade test Jun 23, 2022
test/e2e/cluster_upgrade_test.go Outdated Show resolved Hide resolved
.github/workflows/e2e.yml Outdated Show resolved Hide resolved
@Madhur97 Madhur97 force-pushed the cluster-upgrade-e2e branch 2 times, most recently from b233a17 to 1c89c26 Compare June 24, 2022 05:29
Copy link
Contributor

@dharmjit dharmjit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some basic nits only.

test/e2e/cluster_upgrade_test.go Outdated Show resolved Hide resolved
test/e2e/cluster_upgrade_test.go Outdated Show resolved Hide resolved
test/e2e/cluster_upgrade_test.go Outdated Show resolved Hide resolved
test/e2e/cluster_upgrade_test.go Outdated Show resolved Hide resolved
test/e2e/cluster_upgrade_test.go Outdated Show resolved Hide resolved
@Madhur97 Madhur97 force-pushed the cluster-upgrade-e2e branch 3 times, most recently from 947a9dc to a066085 Compare June 24, 2022 09:57
@Madhur97 Madhur97 force-pushed the cluster-upgrade-e2e branch from a066085 to 9549b2a Compare June 24, 2022 15:07
Copy link
Contributor

@anusha94 anusha94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@anusha94 anusha94 merged commit 2cfdea3 into vmware-tanzu:main Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[E2E] Cluster upgrade test
4 participants