Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clusterclass quickstart and cluster topology template #573

Merged
merged 1 commit into from
Jun 13, 2022
Merged

Clusterclass quickstart and cluster topology template #573

merged 1 commit into from
Jun 13, 2022

Conversation

shivi28
Copy link
Contributor

@shivi28 shivi28 commented May 31, 2022 •
edited
Loading

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #534 ,
Fixes #537

Additional information

  1. Removed byoClusterTemplate.Spec.Template.Spec check from ByoClusterTemplate webhooks as they are handled in ByoCluster webhooks.
  2. Added clusterclass quickstart template
  3. Added cluster topology template, that creates cluster using clusterclass

Special notes for your reviewer

@shivi28 shivi28 force-pushed the cc_534_537 branch 2 times, most recently from 46c2825 to 73e1f45 Compare May 31, 2022 12:41
@shivi28 shivi28 requested a review from anusha94 May 31, 2022 15:19
@shivi28 shivi28 mentioned this pull request Jun 1, 2022
Merged
@shivi28 shivi28 force-pushed the cc_534_537 branch 2 times, most recently from cb69055 to 0153b6d Compare June 3, 2022 13:38
dharmjit
dharmjit reviewed Jun 8, 2022
View reviewed changes
main.go Outdated Show resolved Hide resolved
@sachinkumarsingh092 sachinkumarsingh092 mentioned this pull request Jun 8, 2022
Merged
@shivi28 shivi28 force-pushed the cc_534_537 branch 6 times, most recently from c117abd to 7eb87d5 Compare June 10, 2022 06:51
@shivi28 shivi28 changed the title Clusterclass quickstart and cluster topology template [wip]Clusterclass quickstart and cluster topology template Jun 10, 2022
@shivi28 shivi28 force-pushed the cc_534_537 branch 3 times, most recently from dcdc689 to 61b5eda Compare June 10, 2022 11:38
@shivi28 shivi28 changed the title [wip]Clusterclass quickstart and cluster topology template Clusterclass quickstart and cluster topology template Jun 10, 2022
@shivi28 shivi28 requested a review from dharmjit June 13, 2022 06:58
dharmjit
dharmjit approved these changes Jun 13, 2022
View reviewed changes
Copy link
Contributor

@dharmjit dharmjit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

anusha94
anusha94 approved these changes Jun 13, 2022
View reviewed changes
Copy link
Contributor

@anusha94 anusha94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@anusha94 anusha94 merged commit 48833a2 into vmware-tanzu:main Jun 13, 2022
@vmwclabot
Copy link

@shivi28, VMware has rejected your signed contributor license agreement. The change has already been merged, but it will be backed out by the project maintainers if the agreement is not resigned in a timely manner. Click here to resign the agreement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anusha94 anusha94 anusha94 approved these changes

@dharmjit dharmjit dharmjit approved these changes

Assignees
No one assigned
Labels
area/apis cla-rejected
Projects
None yet
Milestone
No milestone
4 participants
@shivi28 @vmwclabot @dharmjit @anusha94