Fix installer Ubuntu_20.04.3_x86-64 bug #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem When running cli with os flag set to "Ubuntu_20.04.3_x86-64", installer returns "os k8s not supported". Installer is expected to support Ubuntu_20.04.*_x86-64 and treat them as Ubuntu_20.04.1_x86-64. Rootcause Installer runs a check whether there is at least one k8s for the os. It does so by using registry ListK8s. However the latter expects that its argument is an osBundle (Ubuntu_20.04.1_x86-64) as returned by registry ListOS. There is no os bundle for "Ubuntu_20.04.3_x86-64". Fix registry ListK8s needs to support 2 use-cases. First, when called with an actual OS to be mutated. Second, when called with list-supported which may be on a non supported OS. Extend registry ListK8s to use the os regex in addition to the os bundle. Extend registry to return the os bundle in addition to installer.
dharmjit
reviewed
Nov 16, 2021
anusha94
approved these changes
Nov 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When running cli with os flag set to "Ubuntu_20.04.3_x86-64", installer returns
"os k8s not supported". Installer is expected to support Ubuntu_20.04.*_x86-64
and treat them as Ubuntu_20.04.1_x86-64.
Rootcause
Installer runs a check whether there is at least one k8s for the os.
It does so by using registry ListK8s. However the latter expects that
its argument is an osBundle (Ubuntu_20.04.1_x86-64) as returned by
registry ListOS. There is no os bundle for "Ubuntu_20.04.3_x86-64".
Fix
registry ListK8s needs to support 2 use-cases. First, when called
with an actual OS to be mutated. Second, when called with list-supported
which may be on a non supported OS. Extend registry ListK8s to use the os
regex in addition to the os bundle. Extend registry to return the os bundle
in addition to installer.